unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: iyzsong@member.fsf.org (宋文武)
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add libotf.
Date: Fri, 19 Feb 2016 18:29:51 +0800	[thread overview]
Message-ID: <87y4ah6li8.fsf@member.fsf.org> (raw)
In-Reply-To: <87fuwpf23g.fsf@gnu.org> (Roel Janssen's message of "Fri, 19 Feb 2016 11:04:19 +0100")

Roel Janssen <roel@gnu.org> writes:

> From 64cfdae64cfe9af4ff162935edd4e208a0f5afc1 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Fri, 19 Feb 2016 11:00:06 +0100
> Subject: [PATCH] gnu: Add libotf.
>
> * gnu/packages/fontutils.scm (libotf): New variable.
> ---
>  gnu/packages/fontutils.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index 7b5b330..5cd7c56 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -259,6 +259,27 @@ resolution.")
>      (license license:gpl2+)
>      (home-page "http://potrace.sourceforge.net/")))
>  
> +(define-public libotf
> +  (package
> +    (name "libotf")
> +    (version "0.9.13")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://download.savannah.gnu.org/releases/m17n/libotf-"
this line is too long, shouldn’t more than 80 chars.
> +                   version ".tar.gz"))
> +              (sha256
> +               (base32 "0239zvfan56w7vrppriwy77fzb10ag9llaz15nsraps2a2x6di3v"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("freetype" ,freetype)))
No need to be ‘native-inputs’.  And does ‘freetype’ is in the ‘libotf.pc’
file?  If so, this should be in ‘propagate-inputs’.

<https://www.gnu.org/software/guix/manual/html_node/package-Reference.html>
for the details.

> +    (home-page "http://www.nongnu.org/m17n/")
> +    (synopsis "A Library for handling OpenType Font")
> +    (description "The library can read Open Type Layout Tables from OTF file. 
> +Currently these tables are supported; head, name, cmap, GDEF, GSUB, and GPOS.
> +It can convert a Unicode character sequence to a glyph code sequence by using
> +the above tables.")
The ‘synopsis’ shouldn’t start with “A” or “An”, expect for GNU
packages. And I think “This library” is better than “The library”
for ‘description’.
> +    (license license:lgpl2.0+)))
> +
>  (define-public libspiro
>    (package
>      (name "libspiro")

  reply	other threads:[~2016-02-19 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 10:04 [PATCH] Add libotf Roel Janssen
2016-02-19 10:29 ` 宋文武 [this message]
2016-02-19 11:36   ` Roel Janssen
2016-02-20  0:43     ` 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4ah6li8.fsf@member.fsf.org \
    --to=iyzsong@member.fsf.org \
    --cc=guix-devel@gnu.org \
    --cc=roel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).