Re: [PATCH] Add libotf.

[iyzsong@member.fsf.org (宋文武)]

Roel Janssen <roel@gnu.org> writes:

> From 64cfdae64cfe9af4ff162935edd4e208a0f5afc1 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Fri, 19 Feb 2016 11:00:06 +0100
> Subject: [PATCH] gnu: Add libotf.
>
> * gnu/packages/fontutils.scm (libotf): New variable.
> ---
>  gnu/packages/fontutils.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index 7b5b330..5cd7c56 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -259,6 +259,27 @@ resolution.")
>      (license license:gpl2+)
>      (home-page "http://potrace.sourceforge.net/")))
>  
> +(define-public libotf
> +  (package
> +    (name "libotf")
> +    (version "0.9.13")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://download.savannah.gnu.org/releases/m17n/libotf-"
this line is too long, shouldn’t more than 80 chars.
> +                   version ".tar.gz"))
> +              (sha256
> +               (base32 "0239zvfan56w7vrppriwy77fzb10ag9llaz15nsraps2a2x6di3v"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("freetype" ,freetype)))
No need to be ‘native-inputs’.  And does ‘freetype’ is in the ‘libotf.pc’
file?  If so, this should be in ‘propagate-inputs’.

<https://www.gnu.org/software/guix/manual/html_node/package-Reference.html>
for the details.

> +    (home-page "http://www.nongnu.org/m17n/")
> +    (synopsis "A Library for handling OpenType Font")
> +    (description "The library can read Open Type Layout Tables from OTF file. 
> +Currently these tables are supported; head, name, cmap, GDEF, GSUB, and GPOS.
> +It can convert a Unicode character sequence to a glyph code sequence by using
> +the above tables.")
The ‘synopsis’ shouldn’t start with “A” or “An”, expect for GNU
packages. And I think “This library” is better than “The library”
for ‘description’.
> +    (license license:lgpl2.0+)))
> +
>  (define-public libspiro
>    (package
>      (name "libspiro")