[PATCH] guix: use '@' in package-full-name instead of '-'

[PATCH] guix: use '@' in package-full-name instead of '-'

[Cyril Roelandt]

* guix/packages.scm (package-full-name): Use '@' instead of '-'.
---
 guix/packages.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index d62d1f3..e33791e 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -346,7 +346,7 @@ name of its URI."
 
 (define (package-full-name package)
   "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
-  (string-append (package-name package) "-" (package-version package)))
+  (string-append (package-name package) "@" (package-version package)))
 
 (define (%standard-patch-inputs)
   (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
-- 
2.6.2

Re: [PATCH] guix: use '@' in package-full-name instead of '-'

[Eric Bavier]

On Thu, 28 Apr 2016 04:25:23 +0200
Cyril Roelandt <tipecaml@gmail.com> wrote:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>  
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."

Could you replace the '-' here too? --------------^

> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

LGTM!

`~Eric

Re: [PATCH] guix: use '@' in package-full-name instead of '-'

[Mathieu Lirzin]

Cyril Roelandt <tipecaml@gmail.com> writes:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>  
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

Unfortunately, changing this is not as simple.

When implementing the '-' to '@' thing, I have proposed to switch
‘package-full-name’.  While I still think it would make sense for it to
use '@', it would require a full rebuild of every package + extra care.
For example among other things the tests will not be happy for ‘guix
graph‘ IIRC, and the Guix website uses it to access Hydra links.

It would be great if you manage to solve this issue.  :)

Thanks,

-- 
Mathieu Lirzin

Re: [PATCH] guix: use '@' in package-full-name instead of '-'

[Ludovic Courtès]

Mathieu Lirzin <mthl@gnu.org> skribis:

> Cyril Roelandt <tipecaml@gmail.com> writes:
>
>> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
>> ---
>>  guix/packages.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/guix/packages.scm b/guix/packages.scm
>> index d62d1f3..e33791e 100644
>> --- a/guix/packages.scm
>> +++ b/guix/packages.scm
>> @@ -346,7 +346,7 @@ name of its URI."
>>  
>>  (define (package-full-name package)
>>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
>> -  (string-append (package-name package) "-" (package-version package)))
>> +  (string-append (package-name package) "@" (package-version package)))
>>  
>>  (define (%standard-patch-inputs)
>>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
>
> Unfortunately, changing this is not as simple.
>
> When implementing the '-' to '@' thing, I have proposed to switch
> ‘package-full-name’.  While I still think it would make sense for it to
> use '@', it would require a full rebuild of every package + extra care.

No no, no full rebuild, only extra care.  :-)

> For example among other things the tests will not be happy for ‘guix
> graph‘ IIRC, and the Guix website uses it to access Hydra links.

Right, there are a few places that sorta expect a hyphen; the thing that
generates <http://gnu.org/s/guix/packages> is the only one that comes to
mind, though.

When discussing the patch series for the @ syntax, we discussed at one
point making the delimiter of ‘package-full-name’ an optional parameter
that would default to @.  It appears in the patch at:

  https://lists.gnu.org/archive/html/guix-devel/2016-01/msg00873.html

I’m not sure why we dropped it, but we should try to reinstate it.

Cyril, can you make the delimiter an optional argument and see whether
‘make check’ passes?

Thanks!

Ludo’.

Re: [PATCH] guix: use '@' in package-full-name instead of '-'

[Alex Kost]

Cyril Roelandt (2016-04-28 05:25 +0300) wrote:

> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
>  guix/packages.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>  
>  (define (package-full-name package)
>    "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> -  (string-append (package-name package) "-" (package-version package)))
> +  (string-append (package-name package) "@" (package-version package)))
>  
>  (define (%standard-patch-inputs)
>    (let* ((canonical (module-ref (resolve-interface '(gnu packages base))

I recall it was intentionally left untouched.  I don't remember details
but search for 'package-full-name' here:
http://lists.gnu.org/archive/html/guix-devel/2016-01/msg00910.html

Mathieu or Ludovic should know better.

-- 
Alex