Re: [PATCH] Add msgpack

[Lukas Gradl <lgradl@openmailbox.org>]

[-- Attachment #1: Type: text/plain, Size: 2823 bytes --]


Hi,

Thank you for your review!

Efraim Flashner <efraim@flashner.co.il> writes:

> On Mon, May 30, 2016 at 03:50:41PM -0500, Lukas Gradl wrote:
>> 
>> Hello Guix,
>> 
>> Attached is a patch for the c/c++ version of msgpack.  This is a
>> dependency of the Ring.
>> 
>> Thank you!
>> 
>
>> From 25eef52146bc84e83d90e429a0a2a5ca607280bc Mon Sep 17 00:00:00 2001
>> From: Lukas Gradl <lgradl@openmailbox.org>
>> Date: Mon, 30 May 2016 15:46:29 -0500
>> Subject: [PATCH] gnu: serialization: Add msgpack.
>> 
>> * gnu/packages/serialization.scm (msgpack): New variable.
>> ---
>>  gnu/packages/serialization.scm | 31 +++++++++++++++++++++++++++++++
>>  1 file changed, 31 insertions(+)
>> 
>> diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
>> index 8dfd21d..524754b 100644
>> --- a/gnu/packages/serialization.scm
>> +++ b/gnu/packages/serialization.scm
>> @@ -1,5 +1,6 @@
>>  ;;; GNU Guix --- Functional package management for GNU
>>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>> +;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox.org>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -21,7 +22,11 @@
>>    #:use-module (guix packages)
>>    #:use-module (guix download)
>>    #:use-module (guix build-system cmake)
>> +  #:use-module (guix build-system gnu)
>>    #:use-module (gnu packages)
>> +  #:use-module (gnu packages autotools)
>> +  #:use-module (gnu packages check)
>> +  #:use-module (gnu packages compression)
>>    #:use-module (gnu packages documentation))
>>  
>>  (define-public cereal
>> @@ -72,3 +77,29 @@
>>  arbitrary data types and reversibly turns them into different representations,
>>  such as compact binary encodings, XML, or JSON.")
>>      (license license:bsd-3)))
>> +
>> +
>> +(define-public msgpack
>> +  (package
>> +    (name "msgpack")
>> +    (version "1.4.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri
>> +        (string-append
>> +         "https://github.com/msgpack/msgpack-c/releases/download/"
>> +         "cpp-1.4.1/msgpack-" version ".tar.gz"))
>                 ^^^
>             "cpp-" version "/msgpack-"

Oops! The attached patch fixes that.

>
>> +       (sha256
>> +        (base32
>> +         "0bpjfh9vz0n2k93mph3x15clmigkgs223xfn8h12ymrh5gsi5ica"))))
>> +    (build-system gnu-build-system)
>> +    (native-inputs
>> +     `(("googletest" ,googletest)))
>> +    (inputs
>> +     `(("zlib" ,zlib)))
>> +    (home-page "http://www.msgpack.org")
>> +    (synopsis "Binary serialization library")
>> +    (description "Msgpack is a library for C/C++ that implements binary
>> +serialization.")
>> +    (license license:boost1.0)))
>> -- 
>> 2.7.4
>> 

Thank you!

Best,
Lukas



[-- Attachment #2: 0001-gnu-Add-msgpack.patch --]
[-- Type: text/x-patch, Size: 2166 bytes --]

From e079729d0d2318f218115dfeb046c09a970ba355 Mon Sep 17 00:00:00 2001
From: Lukas Gradl <lgradl@openmailbox.org>
Date: Thu, 2 Jun 2016 19:46:34 -0500
Subject: [PATCH] gnu: Add msgpack.

* gnu/packages/serialization.scm (msgpack): New variable.
---
 gnu/packages/serialization.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 8dfd21d..0f65a00 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,7 +22,11 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages check)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation))
 
 (define-public cereal
@@ -72,3 +77,29 @@
 arbitrary data types and reversibly turns them into different representations,
 such as compact binary encodings, XML, or JSON.")
     (license license:bsd-3)))
+
+
+(define-public msgpack
+  (package
+    (name "msgpack")
+    (version "1.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        (string-append
+         "https://github.com/msgpack/msgpack-c/releases/download/"
+         "cpp-" version "/msgpack-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0bpjfh9vz0n2k93mph3x15clmigkgs223xfn8h12ymrh5gsi5ica"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("googletest" ,googletest)))
+    (inputs
+     `(("zlib" ,zlib)))
+    (home-page "http://www.msgpack.org")
+    (synopsis "Binary serialization library")
+    (description "Msgpack is a library for C/C++ that implements binary
+serialization.")
+    (license license:boost1.0)))
-- 
2.7.4