[PATCH] midicsv: new package

[PATCH] midicsv: new package

[John J Foerch]

[-- Attachment #1: Type: text/plain, Size: 111 bytes --]

Hello,

Here is my first attempt at a package, midicsv.  Please let me know what
changes may need to be made.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnu: midicsv: new package --]
[-- Type: text/x-diff, Size: 1944 bytes --]

From 15e6c06398fa8d340b70da391f90e6c69e613f70 Mon Sep 17 00:00:00 2001
From: "John J. Foerch" <jjfoerch@earthlink.net>
Date: Fri, 1 Jul 2016 21:26:55 -0400
Subject: [PATCH] gnu: midicsv: new package

---
 gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index dfc21cc..0013819 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1594,3 +1594,31 @@ for improved Amiga ProTracker 2/3 compatibility.")
 formats, including most audio formats recognized by FFMpeg.")
     (home-page "http://moc.daper.net")
     (license license:gpl2+)))
+
+(define-public midicsv
+  (package
+    (name "midicsv")
+    (version "1.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://www.fourmilab.ch/webtools/midicsv/"
+                                  name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1vvhk2nf9ilfw0wchmxy8l13hbw9cnpz079nsx5srsy4nnd78nkw"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases (delete 'configure))
+       #:make-flags (list "CC=gcc" (string-append "INSTALL_DEST=" %output))))
+    (synopsis "convert MIDI files to and from CSV")
+    (description
+     "midicsv reads a standard MIDI file and decodes it into a CSV
+(Comma-Separated Value) file which preserves all the information in
+the MIDI file.  The ASCII CSV file may be loaded into a spreadsheet
+or database application, or processed by a program to transform the
+MIDI data (for example, to key transpose a composition or extract a
+track from a multi-track sequence).  A CSV file in the format
+created by midicsv may be converted back into a standard MIDI file
+with the csvmidi program.")
+    (home-page "http://www.fourmilab.ch/webtools/midicsv/")
+    (license license:public-domain)))
-- 
2.9.0

Re: [PATCH] midicsv: new package

[Ludovic Courtès]

Hi,

John J Foerch <jjfoerch@earthlink.net> skribis:

> From 15e6c06398fa8d340b70da391f90e6c69e613f70 Mon Sep 17 00:00:00 2001
> From: "John J. Foerch" <jjfoerch@earthlink.net>
> Date: Fri, 1 Jul 2016 21:26:55 -0400
> Subject: [PATCH] gnu: midicsv: new package
>
> ---
>  gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)

I committed it with a GNU-style commit log, and added a copyright line
for yourself (let me know if I got it wrong).

> +    (synopsis "convert MIDI files to and from CSV")
                  ^
I also capitalized this.

These are all cosmetic details; you can read about these and other
conventions at
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.

Thank you for this patch and welcome!  :-)

Ludo’.

Re: [PATCH] midicsv: new package

[John J Foerch]

ludo@gnu.org (Ludovic Courtès) writes:

> Hi,
>
> John J Foerch <jjfoerch@earthlink.net> skribis:
>
>> From 15e6c06398fa8d340b70da391f90e6c69e613f70 Mon Sep 17 00:00:00 2001
>> From: "John J. Foerch" <jjfoerch@earthlink.net>
>> Date: Fri, 1 Jul 2016 21:26:55 -0400
>> Subject: [PATCH] gnu: midicsv: new package
>>
>> ---
>>  gnu/packages/music.scm | 28 ++++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>
> I committed it with a GNU-style commit log, and added a copyright line
> for yourself (let me know if I got it wrong).
>
>> +    (synopsis "convert MIDI files to and from CSV")
>                   ^
> I also capitalized this.
>
> These are all cosmetic details; you can read about these and other
> conventions at
> <https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.
>
> Thank you for this patch and welcome!  :-)
>
> Ludo’.

Thanks a lot!

--
John Foerch