From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add re2. Date: Fri, 19 Aug 2016 10:35:14 +0300 Message-ID: <87y43t43f1.fsf@gmail.com> References: <87eg5qgp2r.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160816175910.GB1260@jasmine> <87r39nzntl.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <87bn0rzanb.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160818204310.GD2393@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baeKj-0003zB-VH for guix-devel@gnu.org; Fri, 19 Aug 2016 03:35:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baeKe-0004z3-V8 for guix-devel@gnu.org; Fri, 19 Aug 2016 03:35:16 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:36101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baeKe-0004yy-NG for guix-devel@gnu.org; Fri, 19 Aug 2016 03:35:12 -0400 Received: by mail-lf0-x244.google.com with SMTP id 33so2711078lfw.3 for ; Fri, 19 Aug 2016 00:35:12 -0700 (PDT) In-Reply-To: <20160818204310.GD2393@jasmine> (Leo Famulari's message of "Thu, 18 Aug 2016 16:43:10 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari (2016-08-18 23:43 +0300) wrote: > On Wed, Aug 17, 2016 at 04:18:48PM +0100, Marius Bakke wrote: >> Marius Bakke writes: >> >> > Leo Famulari writes: >> > >> >> On Mon, Aug 15, 2016 at 02:05:16PM +0100, Marius Bakke wrote: >> >>> >> >>> I wasn't sure where to put this, so went with its own file. It does not >> >>> fully implement PCRE so pcre.scm seems inappropriate. Perhaps that could >> >>> be renamed to regex.scm or similar. >> >> >> >> The patch looks good, but please put it in regex.scm! But, I don't want >> >> to move all the regex packages into this new regex module. Perhaps tre, >> >> since it appears to have no users in our tree. >> > >> > Moved to regex.scm. Thanks! >> >> ..and here is a patch that moves tre.scm over as well. The code is >> unchanged apart from license: prefix. > > When moving packages around, all users of the package need to have their > module imports updated. Copyright attribution must be carefully handled. > And merging the various *-updates branches into master and vice versa > becomes more complicated and prone to error. > > I *think* this patch does it right. And it will really grate on my sense > of aesthetics to have both regex.scm and tre.scm. But, in general, do we > want to make this change? What does everyone think? I agree that having both 'tre' and 're2' packages in "regex.scm" is the right thing. Also I think it would be good to move 'oniguruma' there. As for "pcre.scm", I would also move its content to "regex.scm". What about 'ghc-pcre-light'? It seems natural to keep it in the same file with 'pcre'/'pcre2' or should it stay in "haskell.scm"? But also there are regex libraries for various languages (like 'ghc-regex-posix', 'guile-irregex', 'perl-regexp-common'). I think these shouldn't be moved. -- Alex