unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add python-imagesize.
Date: Sat, 29 Oct 2016 19:31:00 +0100	[thread overview]
Message-ID: <87y417rorf.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20161029092004.2117-1-dannym@scratchpost.org>

[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-imagesize, python2-imagesize): New variables.
> ---
>  gnu/packages/python.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index f7485ad..52c5b5e 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -11349,3 +11349,32 @@ useful as a validator for JSON data.")
>      (description
>        "This package adds SQLAlchemy support to your Flask application.")
>      (license license:bsd-3)))
> +
> +(define-public python-imagesize
> +  (package
> +    (name "python-imagesize")
> +    (version "0.7.1")
> +    (source
> +      (origin
> +      (method url-fetch)
> +      (uri (pypi-uri "imagesize" version))
> +      (sha256
> +        (base32
> +          "0qk07k0z4241lkzzjji7z4da04pcvg7bfc4xz1934zlqhwmwdcha"))))
> +    (build-system python-build-system)
> +    (home-page
> +      "https://github.com/shibukawa/imagesize_py")
> +    (synopsis
> +      "Gets image size of files in variaous formats in Python")

Nit-pick: Can you move the home-page and synopsis to single lines? The
rest LGTM.

> +    (description
> +      "This package allows determination of image size from
> +PNG, JPEG, JPEG2000 and GIF files in pure Python.")
> +    (license license:expat)
> +    (properties `((python2-variant . ,(delay python2-imagesize))))))
> +
> +(define-public python2-imagesize
> +  (let ((base (package-with-python2 (strip-python2-variant python-imagesize))))
> +    (package
> +      (inherit base)
> +      (native-inputs `(("python2-setuptools" ,python2-setuptools)
> +                       ,@(package-native-inputs base))))))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

  reply	other threads:[~2016-10-29 18:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-29  9:20 [PATCH] gnu: Add python-imagesize Danny Milosavljevic
2016-10-29 18:31 ` Marius Bakke [this message]
2016-10-30 18:18   ` [PATCH v2] " Danny Milosavljevic
2016-10-30 19:31     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y417rorf.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).