From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH v2 3/6] gnu: Add python-dulwich. Date: Wed, 18 Jan 2017 18:48:46 +0100 Message-ID: <87y3y88dj5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <8737gxxza3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170118075305.29573-1-dannym@scratchpost.org> <20170118075305.29573-4-dannym@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTuLs-00065C-LN for guix-devel@gnu.org; Wed, 18 Jan 2017 12:48:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTuLp-0005OQ-IJ for guix-devel@gnu.org; Wed, 18 Jan 2017 12:48:52 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49441) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTuLp-0005Nk-A4 for guix-devel@gnu.org; Wed, 18 Jan 2017 12:48:49 -0500 In-Reply-To: <20170118075305.29573-4-dannym@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic , guix-devel@gnu.org --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > * gnu/packages/python.scm (python-dulwich, python2-dulwich): New variables. > --- > gnu/packages/python.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 6c7a6353d..b064c9f47 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -12740,3 +12740,47 @@ Features: > @item Compiles templates into optimized, yet readable, Python code. > @end enumerate") > (license (license:x11-style "file://LICENSE")))) > + > +(define-public python-dulwich > + (package > + (name "python-dulwich") > + (version "0.16.3") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "dulwich" version)) Upstream provides the same releaases on their home page. I would add (uri (list (string-append "https://www.dulwich.io/releases/dulwich-" version ".tar.gz") (pypi-uri "cram" version))) > + (sha256 > + (base32 "0fl47vzfgc3w3rmhn8naii905cjqcp0vc68iyvymxp7567hh6als")))) > + (build-system python-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-before 'check 'fix-tests > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "dulwich/tests/compat/utils.py" > + (("'git'") (string-append "'" > + (assoc-ref inputs "git") > + "/bin/git'"))) Why is this necessary? Git is available in PATH, no? > + (substitute* '("dulwich/tests/test_repository.py" > + "dulwich/tests/test_hooks.py") > + (("#!/bin/sh") (string-append "#!" (which "sh")))) > + (setenv "TEST_RUNNER" "unittest") > + (setenv "PYTHONHASHSEED" "random") > + #t))))) > + (propagated-inputs > + `(("python-fastimport" ,python-fastimport))) > + (native-inputs > + `(("python-mock" ,python-mock) > + ("python-geventhttpclient" ,python-geventhttpclient) > + ("git" ,git))) > + (home-page "https://www.dulwich.io/") > + (synopsis "Git implementation in Python") > + (description "Dulwich is an implementation of the Git file formats and > +protocols written in pure Python.") > + ;; dual-licensed > + (license (list license:asl2.0 license:gpl2+)))) Please clarify whether it's both, or either. Otherwise LGTM, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlh/qn4ACgkQoqBt8qM6 VPoaqwf7BMzTlOYjJiwSIINm6oXhinpdOMBBdPchagIXedaKkSd6ZCta33jyNj/Q uPUGNrl/CYRgw6E3jgvmEwbWl+uttx54W+K9jP4AAgKaDo+YT5HqTNwEfvfcgrsV UVVbsjgjkumW9V7TT5LJROorqHwf7Ys3AQs97PoMxoUz+uH+Tvfk4s8RO81KQqCp dpcSf8HZsmf76YvTUTxbvPkmE2RHpbqLGu6hY/tVFG2yo/iWnSArNsRgfbMK4Epa 7d6rpJnkWcSYinAIvY9I/JQXUiNyL49+Eu+ZN4te+WfUeZvh/4N4CUdR0FFvKGsk fTzRp/ycUIZvJYkuMuYSmWkAvdbk7Q== =5lmf -----END PGP SIGNATURE----- --=-=-=--