From: Marius Bakke <mbakke@fastmail.com>
To: Paul Garlick <pgarlick@tourbillion-technology.com>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add opencascade-oce
Date: Sat, 21 Jan 2017 13:28:51 +0100 [thread overview]
Message-ID: <87y3y461h8.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1484827276.2709.14.camel@tourbillion-technology.com>
[-- Attachment #1: Type: text/plain, Size: 2677 bytes --]
Paul Garlick <pgarlick@tourbillion-technology.com> writes:
> Hello Marius,
> Thank you for your review.
>> I wonder if this could fit in "engineering.scm". Or maybe
>> "geometry.scm"
>> or "3d.scm". We try to avoid "single program" modules. What do you
>> think?
> Perhaps maths.scm is the best place, in order to avoid creating a new
> module. The Gmsh package is already there.
OK, sounds good!
> To check; am I right in
> saying that a library in one module can be used as an input for a
> package in another module? For example, if FreeCAD were to be
> packaged, and placed in engineering.scm, could it use opencascade-oce
> as an input from maths.scm?
That's the intended usage; cross-references are OK too (to an extent).
>> > +(define-public opencascade-oce
>> > + (package
>> > + (name "opencascade-oce")
>> > + (version "0.17.2")
>>
>> Version 0.18 was released a few days ago!
>
> It would be useful to package both versions. There is a difference in
> the OpenGL graphics card requirements in going from version 0.17.2 to
> 0.18.
That sounds sensible. Could you try packaging both versions and add a
comment with 0.17 mentioning the graphics card requirement? See e.g.
'python-requests-2.7' for an example of inheriting another package.
>> >
>> > + (license license:lgpl2.1))) ; plus header files exception
>> >
>
>>
>>
>> Please expand on the exception comment and mention
>> OCCT_LGPL_EXCEPTION.txt. There are also some public domain files, and
>> the bundled "gtest" is bsd-3. src/OpenGl/OpenGl_glext.h is distributed
>> under the expat license. Some files generated by "bison" has GPL3+.
>>
>
> I have added the information about the expat and BSD-3 licenses. Can
> you elaborate on the public domain files and Bison?
At least these two files are public domain:
src/Standard/Standard_StdAllocator.hxx
src/NCollection/NCollection_StdAllocator.hxx
Reading the bison generated files more closely, they contain an
exception saying they can be relicensed as part of a larger work, so I
think they fall under the "main" license in this case. Sorry for the
confusion!
Otherwise the patch looks good. I did notice that some of the inputs are
not referenced as verified with `guix gc -R /gnu/store/...`. Perhaps
they need some configure switches to be enabled? These inputs appear to
be unused, or only needed for building:
ftgl
qt
libtool
file
tk
tcl
Libtool and file should likely be native-inputs, not sure about the
others. Could you check whether they are required and send an updated
patch?
Thanks in advance! This is the final round, promise ;-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-01-21 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 11:23 [PATCH] gnu: Add opencascade-oce Paul Garlick
2017-01-18 18:35 ` Marius Bakke
2017-01-19 12:01 ` Paul Garlick
2017-01-21 12:28 ` Marius Bakke [this message]
2017-01-21 15:13 ` Ludovic Courtès
2017-01-26 16:01 ` Paul Garlick
2017-01-30 9:26 ` Ludovic Courtès
2017-01-20 22:21 ` Paul Garlick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3y461h8.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=pgarlick@tourbillion-technology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).