* [PATCH core-updates] guix: cmake-build-system: Enable offscreen Qt backend for tests.
@ 2017-01-25 20:51 Danny Milosavljevic
2017-01-25 20:57 ` Danny Milosavljevic
2017-01-26 9:59 ` Ludovic Courtès
0 siblings, 2 replies; 3+ messages in thread
From: Danny Milosavljevic @ 2017-01-25 20:51 UTC (permalink / raw)
To: guix-devel
* guix/build/cmake-build-system.scm (cmake-build-system): Set QT_QPA_PLATFORM to "offscreen".
---
guix/build/cmake-build-system.scm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/guix/build/cmake-build-system.scm b/guix/build/cmake-build-system.scm
index 27f2b5c87..dfe61ce56 100644
--- a/guix/build/cmake-build-system.scm
+++ b/guix/build/cmake-build-system.scm
@@ -67,6 +67,8 @@
#:allow-other-keys)
(let ((gnu-check (assoc-ref gnu:%standard-phases 'check)))
(setenv "CTEST_OUTPUT_ON_FAILURE" "1")
+ ;; Automated tests can't access user's X session anyway
+ (setenv "QT_QPA_PLATFORM" "offscreen")
(gnu-check #:tests? tests? #:test-target test-target
#:parallel-tests? parallel-tests?)))
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH core-updates] guix: cmake-build-system: Enable offscreen Qt backend for tests.
2017-01-25 20:51 [PATCH core-updates] guix: cmake-build-system: Enable offscreen Qt backend for tests Danny Milosavljevic
@ 2017-01-25 20:57 ` Danny Milosavljevic
2017-01-26 9:59 ` Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Danny Milosavljevic @ 2017-01-25 20:57 UTC (permalink / raw)
To: guix-devel
Note: If we do that, we should adapt the packages openimageio, kconfig, kidletime, kitemviews, kplotting, kwidgetsaddons, kcrash, kimageformats, kdeclarative because these currently invoke Xvfb which would be later unnecessary (but harmless, I think).
Not sure why kwidgetsaddons does both set QT_QPA_PLATFORM=offscreen AND invoke Xvfb... why?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH core-updates] guix: cmake-build-system: Enable offscreen Qt backend for tests.
2017-01-25 20:51 [PATCH core-updates] guix: cmake-build-system: Enable offscreen Qt backend for tests Danny Milosavljevic
2017-01-25 20:57 ` Danny Milosavljevic
@ 2017-01-26 9:59 ` Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2017-01-26 9:59 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * guix/build/cmake-build-system.scm (cmake-build-system): Set QT_QPA_PLATFORM to "offscreen".
> ---
> guix/build/cmake-build-system.scm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/guix/build/cmake-build-system.scm b/guix/build/cmake-build-system.scm
> index 27f2b5c87..dfe61ce56 100644
> --- a/guix/build/cmake-build-system.scm
> +++ b/guix/build/cmake-build-system.scm
> @@ -67,6 +67,8 @@
> #:allow-other-keys)
> (let ((gnu-check (assoc-ref gnu:%standard-phases 'check)))
> (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
> + ;; Automated tests can't access user's X session anyway
> + (setenv "QT_QPA_PLATFORM" "offscreen")
I agree it’s a good idea to factorize it somewhere, but it doesn’t
really belong in cmake-build-system, does it?
OTOH it can’t hurt to have it here.
Thoughts?
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-26 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-25 20:51 [PATCH core-updates] guix: cmake-build-system: Enable offscreen Qt backend for tests Danny Milosavljevic
2017-01-25 20:57 ` Danny Milosavljevic
2017-01-26 9:59 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).