From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH core-updates] guix: cmake-build-system: Enable offscreen
	Qt backend for tests.
Date: Thu, 26 Jan 2017 10:59:09 +0100
Message-ID: <87y3xy3zwy.fsf@gnu.org>
References: <20170125205118.15212-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41384)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cWgpn-000764-3M
	for guix-devel@gnu.org; Thu, 26 Jan 2017 04:59:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cWgpk-0006NM-12
	for guix-devel@gnu.org; Thu, 26 Jan 2017 04:59:15 -0500
In-Reply-To: <20170125205118.15212-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Wed, 25 Jan 2017 21:51:18 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * guix/build/cmake-build-system.scm (cmake-build-system): Set QT_QPA_PLAT=
FORM to "offscreen".
> ---
>  guix/build/cmake-build-system.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/guix/build/cmake-build-system.scm b/guix/build/cmake-build-s=
ystem.scm
> index 27f2b5c87..dfe61ce56 100644
> --- a/guix/build/cmake-build-system.scm
> +++ b/guix/build/cmake-build-system.scm
> @@ -67,6 +67,8 @@
>                  #:allow-other-keys)
>    (let ((gnu-check (assoc-ref gnu:%standard-phases 'check)))
>      (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
> +    ;; Automated tests can't access user's X session anyway
> +    (setenv "QT_QPA_PLATFORM" "offscreen")

I agree it=E2=80=99s a good idea to factorize it somewhere, but it doesn=E2=
=80=99t
really belong in cmake-build-system, does it?

OTOH it can=E2=80=99t hurt to have it here.

Thoughts?

Ludo=E2=80=99.