From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: Re: problem with commit abae042
Date: Sat, 15 Apr 2017 21:13:55 +0200
Message-ID: <87y3v1h4b0.fsf@gmail.com>
References: <20170402135242.2958-1-m.othacehe@gmail.com>
	<20170402135242.2958-17-m.othacehe@gmail.com>
	<20170415184756.10b178be@scratchpost.org>
	<871sstilgo.fsf@gmail.com>
	<20170415205631.46af6c48@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57459)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <m.othacehe@gmail.com>) id 1czT91-0001YZ-AV
	for guix-devel@gnu.org; Sat, 15 Apr 2017 15:14:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <m.othacehe@gmail.com>) id 1czT8w-0001nQ-Dk
	for guix-devel@gnu.org; Sat, 15 Apr 2017 15:14:03 -0400
Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34151)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <m.othacehe@gmail.com>)
	id 1czT8w-0001nB-6N
	for guix-devel@gnu.org; Sat, 15 Apr 2017 15:13:58 -0400
Received: by mail-wm0-x244.google.com with SMTP id z129so735168wmb.1
	for <guix-devel@gnu.org>; Sat, 15 Apr 2017 12:13:58 -0700 (PDT)
In-reply-to: <20170415205631.46af6c48@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 26339@debbugs.gnu.org, guix-devel <guix-devel@gnu.org>


> Too bad this is such a huge changeset - it's quite difficult to find a safe path.

Yes, and my split between commit isn't great, sorry about that.

> Do you have an idea how to fix it? 

Nothing trivial. Plus I didn't notice before that
profile-bootloader-entries and operating-system-bootcfg had parts that
could have been factorized.

>
> Would it be good to press forward with the other patches or should I back it out?

Maybe the safer approch would be to revert this commit. I'll publish new
patches and try to find a better approach for
profile-bootloader-entries, if you're ok ?

Thank you,

Mathieu