From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Marusich Subject: Re: "python setup.py test" is deprecated Date: Thu, 08 Aug 2019 18:41:40 -0700 Message-ID: <87y303yv1n.fsf@gmail.com> References: <87blx33jlx.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:35769) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvtuf-0004xP-Py for guix-devel@gnu.org; Thu, 08 Aug 2019 21:41:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvtuf-0006mD-46 for guix-devel@gnu.org; Thu, 08 Aug 2019 21:41:49 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]:36156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvtue-0006m0-SN for guix-devel@gnu.org; Thu, 08 Aug 2019 21:41:49 -0400 Received: by mail-pf1-x429.google.com with SMTP id r7so45127883pfl.3 for ; Thu, 08 Aug 2019 18:41:48 -0700 (PDT) In-Reply-To: <87blx33jlx.fsf@devup.no> (Marius Bakke's message of "Mon, 05 Aug 2019 14:03:06 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Pythons setuptools are deprecating the "python setup.py test" command: > > https://github.com/pypa/setuptools/issues/1684 > > As you may know, "python setup.py test" is what python-build-system does > during the 'check' phase. > > I'm not sure what we should do about it, and there does not seem to be > an established "community consensus" yet. I suppose many packages will > be migrating to Pytest and/or Tox? Perhaps we could check package > inputs and try to guess the correct test command? > > Something to keep in mind for future python-build-system improvements... > > PS: Apparently "python setup.py install" is going away too: > https://github.com/pypa/setuptools/issues/1684#issuecomment-508302910 To my knowledge, the "targets" of the setup.py script are somewhat not standardized, even though they seem like they ought to be. At the very least, you are right about the "test" target. Even pytest dropped support for it since last year: https://docs.pytest.org/en/latest/changelog.html?highlight=3D%22setup.py%20= test%22#id511 This is just one example of how a project can implement its own idiosyncratic build logic. Somebody uses tox, someone else uses a Makefile with a "check" target (that runs pytest), somebody else just runs pytest directly... It's business as usual as far as I can tell. Guix can accommodate all those idiosyncrasies via modifications to the phases, and if the Python community starts using one method much more often, we can just make that the default in the build system. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAl1Mz1QACgkQ3UCaFdgi Rp1JqxAA0uMwWjopvfBWNZDTaVcMX9aWsNO88hOrehQZeNHXcoQprmtZqQHGva8o 2ngxX511ivD9qZkMGpTEGJ9BIFPlwHfMhCz4AO7+eFOkBdmtA8CaTPnZALV25sLn tpWwPjV41H0PfXaRy2gKqbLIUz9aAhIU3sf8uH9hnuFEZk+KoSs4tEn566d4WW1W 8/vWqnGjjneiJN/N5OsGbwmZRIyJpc86Qp+ZulEA0+AKNYHhjFk1j8hQK56Igc2f MXiiyeRwxif+Xbx7O41KCuRho4DQY+2LqeLDMwhp4GNBdS8UEopEY0YMVrdCNasb sY678SxwVMf2jarYmG4JJqbBe2t6JYEpr+86JzIJ5NPOZFzQfbWZqbR3K3N6/ieR H1qNxahM4aerrvBSY141BhQZ/ATDsO/eWnD0Ch678xocpGGewCFQKkaeanscVjz3 AMk2bYsw4JDPGKxkUOpxs8OADk5/TXqJ9xunf4+z++T6uWUveRUdkwhvA9tgf/s0 SbdT/wSMtNsXTKe9kCjRbFseOBfRlNrgejuRyjE74Xd2/WI0bOIg+G+YV5Nj/zIG MZbpmis2NguFtsK+6CRwujCcfFwe8izL1pSLyb0cQbdmqLt8sFIyC4PinQ5Z5U9U XSReG7ut/B4qHNubSONwIizjph2XkfTAvbr7cvbvunvNyGpeBCw= =2G8u -----END PGP SIGNATURE----- --=-=-=--