From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sdN4ByZJq17CGAAA0tVLHw (envelope-from ) for ; Thu, 30 Apr 2020 21:54:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id IFMALS9Jq16oewAAbx9fmQ (envelope-from ) for ; Thu, 30 Apr 2020 21:54:55 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 40E25941CAB for ; Thu, 30 Apr 2020 21:54:54 +0000 (UTC) Received: from localhost ([::1]:47794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUH8w-0001LE-CT for larch@yhetil.org; Thu, 30 Apr 2020 17:54:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33844) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUH4p-0007el-39 for guix-devel@gnu.org; Thu, 30 Apr 2020 17:54:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59258) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUH4n-00047b-26 for guix-devel@gnu.org; Thu, 30 Apr 2020 17:50:37 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35710 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUH4l-0008IQ-HG for guix-devel@gnu.org; Thu, 30 Apr 2020 17:50:36 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-devel@gnu.org Subject: Re: 05/36: vm: Make the device node procedure a parameter. References: <20200427101927.7020.76060@vcs0.savannah.gnu.org> <20200427101943.A4BDD20A5E@vcs0.savannah.gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 =?utf-8?Q?Flor=C3=A9al?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 30 Apr 2020 23:50:34 +0200 In-Reply-To: <20200427101943.A4BDD20A5E@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Mon, 27 Apr 2020 06:19:43 -0400 (EDT)") Message-ID: <87y2qcmymt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49465681532209]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.17), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[ludo@gnu.org,guix-devel-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[]; URIBL_BLOCKED(0.00)[gnu.org:email]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[gnu.org]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: sqQ04qZJvDp7 Hi, guix-commits@gnu.org skribis: > commit ddb44df650592a29528ef3f4a913336230b1d3a1 > Author: Ludovic Court=C3=A8s > AuthorDate: Tue Apr 7 10:21:48 2020 +0200 > > vm: Make the device node procedure a parameter. >=20=20=20=20=20 > * gnu/build/vm.scm (root-partition-initializer): Add #:make-device-no= des > parameter and use it. > * gnu/system/vm.scm (qemu-image): Add #:device-node parameter. Pass > #:make-device-nodes to 'root-partition-initializer'. > * gnu/system/hurd.scm (cross-hurd-image): Pass #:device-nodes 'hurd to > 'qemu-image'. > --- > gnu/system/hurd.scm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gnu/system/hurd.scm b/gnu/system/hurd.scm > index 2583ff0..059bfaf 100644 > --- a/gnu/system/hurd.scm > +++ b/gnu/system/hurd.scm > @@ -209,6 +209,7 @@ fi\n")) > #:bootcfg-drv grub.cfg > #:bootloader grub-bootloader > #:register-closures? #f > + #:device-nodes 'hurd > #:extra-directives hurd-directives)) On =E2=80=98core-updates=E2=80=99, there=E2=80=99s already #:device-nodes '= hurd, though not on the same line. I think we can drop this patch, no? Ludo=E2=80=99.