From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OPS4KR7bsl62dQAA0tVLHw (envelope-from ) for ; Wed, 06 May 2020 15:43:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sGRiHyrbsl63agAA1q6Kng (envelope-from ) for ; Wed, 06 May 2020 15:43:38 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60C4E940F51 for ; Wed, 6 May 2020 15:43:36 +0000 (UTC) Received: from localhost ([::1]:55080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWMCu-00007v-Ub for larch@yhetil.org; Wed, 06 May 2020 11:43:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWMCl-00007Q-AY for guix-devel@gnu.org; Wed, 06 May 2020 11:43:27 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:57979) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWMCg-0001MG-Qr for guix-devel@gnu.org; Wed, 06 May 2020 11:43:27 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4A7DA258; Wed, 6 May 2020 11:43:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 06 May 2020 11:43:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=Lrlum1FVMpal+tNPdAF81gZwSO eeHWTWTtKfoWp79ms=; b=lwjHroEsMz13p8+r/cdoRml77wogQqyxPUZo9hHLTu 8hQxhqtdtJ30aeqk3MTkSEpkQNkVs0tl0mkZ/5khRwOG0qBfY314WzhsubR1Q0YQ /0PxaawLVJShgxBpYuM67Es0tSHc9UJXS5iG6qn8uFPadaXiKsl9NNNGaklYXeTh iaSDGm6+OCjaIGMEVKBFGW5U7+UQInBksqapNw4EzQennntcnzb2+D+NRdX+LOU+ uGOtQcTYOa4onXl8c4RF3y9DHGGHZKH9Qa+Heg4e5juyovQJTMInHsCX7f4pGW/f 0+gFP9BrbjxHv4ABJYygtBXfF4rMPo8JhuwzNpIdP++Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Lrlum1 FVMpal+tNPdAF81gZwSOeeHWTWTtKfoWp79ms=; b=dhrghQX50D/kSRiIPmh6/r Z4fe753YbcWFYt5//ttbeQb1kaxGkbNpqhv3D6Es8UT3igrvnscoDWbD/j5T0Ek6 p0DaPRFLo+dANh0/HA0+xWwwAf3pMVHP1KqJS6btN4r8nQDMDNzidj95xfWTImGy ReFnBJVGTBw/+9QoeSEtwJYLp4qNg9z3ZlzPf01HalZUqCE3dzNsL/uk2uqL4Gir fkypIqwoVPgYrOFwtrCgXlpP1lXi44wjXa14bzXx7UTIzGw3s9AjwcL0RIzS5sqb YkZAffQ6oJY8sHcC0o8LCMs24oheeXhtWhbFhQsCL0qI8Ec8ktce3cPq1Qdy34fQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeekgdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhiuhhs uceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecuggftrfgrth htvghrnheptddvgfegveegiedvffeujeeitdetvdektddugffgtdegfeeitdeikeffudfg ueffnecukfhppeekgedrvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D2FC306611D; Wed, 6 May 2020 11:43:20 -0400 (EDT) From: Marius Bakke To: Danny Milosavljevic , guix-devel@gnu.org Subject: Re: branch master updated: gnu: gnome-todo: Fix build. In-Reply-To: <20200506153829.27942.8541@vcs0.savannah.gnu.org> References: <20200506153829.27942.8541@vcs0.savannah.gnu.org> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Wed, 06 May 2020 17:43:18 +0200 Message-ID: <87y2q5m5m1.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=64.147.123.24; envelope-from=mbakke@fastmail.com; helo=wout1-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 11:43:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 X-Spam-Score: -1.31 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=fastmail.com header.s=fm2 header.b=lwjHroEs; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=dhrghQX5; dmarc=pass (policy=none) header.from=fastmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Scan-Result: default: False [-1.31 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.4965058188595]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; FREEMAIL_FROM(0.00)[fastmail.com]; DWL_DNSWL_FAIL(0.00)[fastmail.com:server fail,2001:470:142::17:server fail]; R_MISSING_CHARSET(2.50)[]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.12), country: US(-0.00), ip: 2001:470:142::17(-0.50)]; DKIM_TRACE(0.00)[fastmail.com:+,messagingengine.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[fastmail.com,none]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; TAGGED_FROM(0.00)[larch=yhetil.org]; FROM_NEQ_ENVFROM(0.00)[mbakke@fastmail.com,guix-devel-bounces@gnu.org]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[fastmail.com:s=fm2,messagingengine.com:s=fm2]; URIBL_BLOCKED(0.00)[fastmail.com:dkim,messagingengine.com:dkim,gnu.org:email,scratchpost.org:email]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[2001:470:142::17:from]; RCVD_COUNT_SEVEN(0.00)[7]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: bOX0gA9L5LGy --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Danny, guix-commits@gnu.org writes: > commit b17b29454d5edd61eecb4536461789b7a3865a9a > Author: Danny Milosavljevic > AuthorDate: Wed May 6 17:36:03 2020 +0200 > > gnu: gnome-todo: Fix build. >=20=20=20=20=20 > * gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch: New= file. > * gnu/packages/gnome.scm (gnome-todo)[source]: Add it. > * gnu/local.mk (dist_patch_DATA): Add it. Thanks for fixing GNOME Todo! [...] > diff --git a/gnu/packages/patches/gnome-todo-delete-esource-duplicate.pat= ch b/gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch > new file mode 100644 > index 0000000..9e9c2e2 > --- /dev/null > +++ b/gnu/packages/patches/gnome-todo-delete-esource-duplicate.patch > @@ -0,0 +1,7 @@ > +--- gnome-todo-3.28.1/plugins/eds/gtd-eds-autoptr.h.orig 2020-05-06 14:2= 0:49.589902539 +0200 > ++++ gnome-todo-3.28.1/plugins/eds/gtd-eds-autoptr.h 2020-05-06 14:20:54.= 593919721 +0200 > +@@ -25,4 +25,3 @@ > + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalComponent, g_object_unref); > + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalComponentId, e_cal_component_free_id= ); > + G_DEFINE_AUTOPTR_CLEANUP_FUNC (ECalClient, g_object_unref); > +-G_DEFINE_AUTOPTR_CLEANUP_FUNC (ESource, g_object_unref); Can you add a short comment at the top of the patch file explaining what this does, along with links to relevant upstream commits/issues (if applicable)? That way future packagers don't have to reverse-engineer your patch to figure out what it does / whether it is still needed. TIA! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6y2xYACgkQoqBt8qM6 VPpHCQf9HLvAOlXViDA8C0Z/OxbZ95y1ci77+WeRERplw2sgYgpc7hjZmlSTdiQi 7cSSdKnv5NPq0EQqZiLls9lNxkA7NeT9A+l8cMbY45OAu58kCC4hkiuCDE4+no1B mGct8J96HnkqGx0De+2OHs/nu9Oy9i36MLSsg/KtDSmJdFxwa+0d7EVxBxeWFATY w3qxPEi99kZuVzo4zwu7OjH/vXC/jXN5q14MMjdxPwfozoqEkrsQTgnEhhG0g6/S yuY0q+bx8P1uKWCqYxBR8R8PbJ8rOtulWa2s/OhL/VdC0VueHq649oCuyb4yObV8 qa7jwim9x5xiRVVE96x7HMbh34dL8w== =qu9f -----END PGP SIGNATURE----- --=-=-=--