From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mIFQCVDeyl75YwAA0tVLHw (envelope-from ) for ; Sun, 24 May 2020 20:51:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4I86BVDeyl7MLgAAB5/wlQ (envelope-from ) for ; Sun, 24 May 2020 20:51:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 945C49404C8 for ; Sun, 24 May 2020 20:51:27 +0000 (UTC) Received: from localhost ([::1]:36854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcxag-0008Qy-It for larch@yhetil.org; Sun, 24 May 2020 16:51:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44380) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcxaY-0008Pe-UF for guix-devel@gnu.org; Sun, 24 May 2020 16:51:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37439) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcxaY-0004rG-6W; Sun, 24 May 2020 16:51:18 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54926 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jcxaX-0000Bv-Ms; Sun, 24 May 2020 16:51:18 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Andre Batista Subject: Re: [PATCH] Add Tor client only package definition References: <20200517031127.GA17209@andel> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 Prairial an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 24 May 2020 22:51:16 +0200 In-Reply-To: <20200517031127.GA17209@andel> (Andre Batista's message of "Sun, 17 May 2020 00:11:27 -0300") Message-ID: <87y2phys3f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: NsNDjzPOcXr5 Hi Andre, Andre Batista skribis: > Starting on version 0.4.3.5, Tor provides a configuration flag to > disable relay code (--disable-module-relay). Considering most > people are running clients, not relays, I thought it would be > nice for guix to have a client-only package definition (maybe > it could even be the default?). What do you think? What difference does it make, for instance in terms of the total size returned by =E2=80=9Cguix size tor-client=E2=80=9D vs. =E2=80=9Cguix size t= or=E2=80=9D? Are there other considerations, such as a reduced attack surface? > I've tested the code below and it works as expected on my guix > install. However, since I'm neither a schemer nor guixpert, fell > free to teach me how to do it the guix way. It looks good to me overall! Some nitpicking: > + (define-public tor-client > + (package > + (inherit tor) > + (name "tor-client") > + (arguments > + `(#:configure-flags > + `(,@(cons "--disable-module-relay" > + ,(cadr (package-arguments tor)))))) We=E2=80=99d rather use =E2=80=98substitute-keyword-arguments=E2=80=99 to a= ugment #:configure-flags without touching the other keyword arguments (there are several examples in the source). > + (synopsis "Client to the anonymous Tor network") > + (description > + (string-append (package-description tor) > + "\n\nThis package only provides the client funcionality to the Tor > +Network. If you want to setup a relay you need to install @code{tor}.")= ))) We generally avoid concatenating text like this, for the reasons explained at: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html Regarding the format of patches, you can take a look at this: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html Thanks, Ludo=E2=80=99.