unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Carlo Zancanaro <carlo@zancanaro.id.au>
To: "Jakub Kądziołka" <kuba@kadziolka.net>
Cc: guix-devel@gnu.org
Subject: Re: Why does %build-inputs contain the transitive closure of inputs?!
Date: Sat, 08 Aug 2020 10:26:08 +1000	[thread overview]
Message-ID: <87y2mqm19b.fsf@zancanaro.id.au> (raw)
In-Reply-To: <20200807230839.n4zussxemc2sxcp3@gravity>

Hi Jakub,

On Sat, Aug 08 2020, Jakub Kądziołka wrote:
> Why? I would expect only libgit2 to be present, and not all of 
> its dependencies. ...

If you take a look at the definition for libgit2 in 
gnu/packages/version-control.scm you'll see that this isn't all 
the dependencies for libgit2, it's only the propagated-inputs. For 
instance, libssh2 and http-parser are both inputs for libgit2, but 
they don't appear in your list because they're not propagated.

> ... It seems to me that this has only downsides - the entire 
> transitive closure needs to be present during build, even when 
> the actually used dependencies don't reference it, and the names 
> of inputs used by packages are now public API, and changing them 
> can break the build of any transitively dependent package.

The way propagated inputs work is that they're installed alongside 
the package, so in some sense they are part of the public API of 
the package. They should be used with care, but as far as I can 
tell everything is working properly here.

Carlo


  reply	other threads:[~2020-08-08  0:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07 23:08 Why does %build-inputs contain the transitive closure of inputs?! Jakub Kądziołka
2020-08-08  0:26 ` Carlo Zancanaro [this message]
2020-08-08  0:56   ` Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2mqm19b.fsf@zancanaro.id.au \
    --to=carlo@zancanaro.id.au \
    --cc=guix-devel@gnu.org \
    --cc=kuba@kadziolka.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).