From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v2] .dir-locals.el: Automatically set the GEISER-GUILE-LOAD-PATH variable.
Date: Tue, 27 Oct 2020 12:53:12 -0400 [thread overview]
Message-ID: <87y2jrwqyv.fsf@gmail.com> (raw)
In-Reply-To: <877drdp68p.fsf@gmail.com> ("Miguel Ángel Arruga Vivas"'s message of "Mon, 26 Oct 2020 12:38:14 +0100")
Hello Miguel!
Miguel Ángel Arruga Vivas <rosen644835@gmail.com> writes:
> Hello, Maxim!
>
> Thanks for your effort in this, some comments with the quotes for
> context.
Thanks for your comments, they've already made this proposed change much
better!
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>>> This fails if geiser-guile-load-path does not exist (void-variable).
>>> The cleanup removes other guixes, isn't it? I suggest making the
>>> variable buffer-local and forget about hard-coded names. :-)
>>
>> That's a good suggestion! I toyed with it and it's a bit tricky but I
>> think the v2 patch I'll send as a follow-up does the trick. My concern
>> was also supporting when a user has previously set
>> geiser-guile-load-path in their .emacs init file, e.g.:
>>
>> (setq geiser-guile-load-path (list (expand-file-name "~/src/guix")
>> (expand-file-name "~/src/shepherd")))
>>
>> That would mean their entries don't get cleaned up (it seems this
>> doesn't matter in my latest tests with the v2 patch though!).
>
> That cleanup seems to me responsibility of that .emacs maintainer
> instead of something to take into account in .dir-locals. ;-)
Indeed, it could be seen that way! The good news is that it doesn't
seem to cause any problems anyway, should they forget an entry for Guix
there.
>>> (eval . (setq guix-directory
>>> (locate-dominating-file default-directory ".dir-locals.el")))
>>> (eval . (when (boundp 'geiser-guile-load-path)
>>
>> This check makes it so that if geiser-guile-load-path is not already
>> defined, nothing happens. It is likely that this is the case, as when
>> relying on just Geiser's autoloads, it is not loaded. The user would
>> have to either set explicitly before hand or call (require
>> 'geiser-guile), which we can't rely on. But we can drop this check.
>
> You're right, as you can only bind the keys and enable it when used, not
> at file load as I do, great catch. :-)
>
>> One thing that worried me was the %load-compiled-path not appearing in
>> the order defined from guile-geiser-load-path, but in my latest tests as
>> mentioned above it didn't matter.
>
> With the right directories (meaning no-conflicts between modules) it
> shouldn't matter, but it's weird. Looking into geiser-guile.el the load
> path is provided to guile through -L parameters in
> geiser-guile--parameters, and the extra path for Geiser code is added
> with geiser-guile--set-geiser-load-path (that's why it is not added to
> %load-compiled-path)... I'd have to check Guile to be sure why are the
> differences, but they seem harmless.
OK, thank you for investigating!
>> + (unless (fboundp 'geiser-guile-load-path)
>> + (defvar geiser-guile-load-path '()))
>
> This checks the function definition, not the variable, as Emacs Lisp has
> two separate namespaces.
Oops, good catch!
>> I ended up using `cl-pushnew' here instead of push, as otherwise
>> repeated entries were accumulated.
>
> I wanted to avoid exactly that check, as the variable should end up with
> duplicated entries only when you call it twice from the same buffer, how
> could that happen?
>
>> + (make-local-variable 'geiser-guile-load-path)
>> + (cl-pushnew root-dir* geiser-guile-load-path
>> + :test #'string-equal)))))
>
> If there is some way this may happen, then this call is OK, but I'd try
> to stay with a cheaper push unless it's really needed, as O(1) < O(n),
> for almost every n. :-)
The way I could easily trigger this was to open a dired buffer, and
hitting 'g' to refresh its contents.
> Again, thank you very much for taking care of this, as it would make
> life easier for everybody of us who uses Geiser.
I'm glad to read it! :-)
I'll be sending a v3 with the fboundp woopsie above fixed.
Maxim
next prev parent reply other threads:[~2020-10-27 16:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 18:08 [PATCH] Automatically set `geiser-guile-load-path' from .dir-locals Maxim Cournoyer
2020-10-25 18:13 ` Pierre Neidhardt
2020-10-25 18:42 ` [PATCH] .dir-locals.el: Automatically set the GEISER-GUILE-LOAD-PATH variable Maxim Cournoyer
2020-10-25 18:52 ` Pierre Neidhardt
2020-10-25 21:37 ` Maxim Cournoyer
2020-10-25 21:01 ` Miguel Ángel Arruga Vivas
2020-10-26 5:47 ` Maxim Cournoyer
2020-10-26 5:53 ` [PATCH v2] " Maxim Cournoyer
2020-10-26 7:56 ` Pierre Neidhardt
2020-10-26 11:38 ` Miguel Ángel Arruga Vivas
2020-10-27 16:53 ` Maxim Cournoyer [this message]
2020-10-27 18:58 ` Miguel Ángel Arruga Vivas
2020-10-27 17:44 ` [PATCH v3] " Maxim Cournoyer
2020-10-31 4:19 ` Maxim Cournoyer
2020-11-01 1:02 ` Miguel Ángel Arruga Vivas
2020-10-26 13:43 ` [PATCH] Automatically set `geiser-guile-load-path' from .dir-locals zimoun
2020-10-26 15:03 ` Pierre Neidhardt
2020-11-05 2:20 ` Christopher Lemmer Webber
2020-11-05 4:00 ` Christopher Lemmer Webber
2020-11-05 9:25 ` Miguel Ángel Arruga Vivas
2020-11-05 17:26 ` Christopher Lemmer Webber
2020-11-14 19:57 ` Christopher Lemmer Webber
2020-11-16 4:18 ` Maxim Cournoyer
2020-11-16 14:54 ` Miguel Ángel Arruga Vivas
2020-11-16 17:41 ` Christopher Lemmer Webber
2020-11-16 18:07 ` Christopher Lemmer Webber
2020-11-16 20:57 ` Miguel Ángel Arruga Vivas
2020-11-16 23:09 ` Christopher Lemmer Webber
2020-11-17 15:36 ` Maxim Cournoyer
2020-11-18 10:12 ` Miguel Ángel Arruga Vivas
2020-11-05 14:21 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2jrwqyv.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=rosen644835@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).