From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8HSRIqy6l2HtxAAAgWs5BA (envelope-from ) for ; Fri, 19 Nov 2021 15:54:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gPgnHqy6l2G0IQAAB5/wlQ (envelope-from ) for ; Fri, 19 Nov 2021 14:54:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E361DC26 for ; Fri, 19 Nov 2021 15:54:36 +0100 (CET) Received: from localhost ([::1]:39738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo5Hf-0007an-Fo for larch@yhetil.org; Fri, 19 Nov 2021 09:54:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo5HN-0007XY-GX for guix-devel@gnu.org; Fri, 19 Nov 2021 09:54:17 -0500 Received: from [2001:470:142:3::e] (port=37694 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo5HL-0006Zf-B1; Fri, 19 Nov 2021 09:54:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=zTRgB9+KRWUT53/m4dcCrvZffSOkGSYaUs/XtaY+Juk=; b=jeZrZhdzl65FvdJihPC4 0k2381ugq2unhmA5hXSNvKPMYOpC6dWdUX2xh9c2IQTbjkvnb+Arqbg9PDcPqHQy0xyBClAgYZfNr eW4yNELLUmEDkdSZ6pfTjKyUXRosIr8pW5q466i4+QVBsY/G4Aw3qwS5v+pt8dzwrfWVkRoxpIYM7 hUVfV0QUOnyx68by5oT6ozUaPFNiHuR56C3nfYKRpzeqqZ+RwbPLjdIdNfz7ZOKPjbcXAJur9I67t HSsCUzysQyxZpqCei0XVlfmjefRNusZUwCP1t7bzTRqwJ3hcgFooCDkcRRtUuF3khZGs6Th1HD1gX TaH8iF1NEc3WDg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=47290 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo5HL-0002jp-3k; Fri, 19 Nov 2021 09:54:15 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Vagrant Cascadian Subject: Re: default tar format for "make dist" and patch file length References: <87sfvxhrav.fsf@ponder> <874k8bxbit.fsf@gnu.org> <87fsru8l05.fsf@ponder> <87czmy8hr6.fsf@ponder> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 Brumaire an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 19 Nov 2021 15:54:13 +0100 In-Reply-To: <87czmy8hr6.fsf@ponder> (Vagrant Cascadian's message of "Wed, 17 Nov 2021 15:49:49 -0800") Message-ID: <87y25kjiwa.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637333676; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=zTRgB9+KRWUT53/m4dcCrvZffSOkGSYaUs/XtaY+Juk=; b=qZ5NaWrof6cMtM444X3J5iz+XvSyh34k+ybTPv8HGjVjJZodZKEXD4IQYgVCM2o9a8MeuR jSYdUUS73/x1tKw6Rm/041JNeJZBaJtvmGgwnC1K1RgrSjDyjbQQrdclsvU891DT208By2 wNj/Pr6WZxvYJe4xH0rTXWgV7GYUkq5aSobTSE8p54dlNI/ugjbvts8Zj7jm/6xCn3BAxr 9uIMtBTDHTSlUgv5IT0PCBrDjvCpOPfkF/7SePqsGIvZGRCoChJ05RGPdkpycs9F4llkPp DKZ9iuUCaqZu8ZKgnt5VDjO6HkhPkDWYYdh4Kyz/zWpl2JK2HawnV8Y5QrMSUw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637333676; a=rsa-sha256; cv=none; b=TiSVISEtIxZ3h3Xtdt95iYNXdDMSzRkzYJ0Ab43y0NXmxeP3Blre0doKgrGBTA8pBud1hb acV0UK4jmiVMufow4soai7kRO+uRCG5hkCqY5g4toAJAtbYo0pW71lyroUX08rlPC4tEVx QPOxm2f9qXQiUGVyXnLFXfIu1JSGXYzEQesyQJBtpWs60YXejgApoNYm1USbvo0ipm9QRD dngZ7cyx58eSgdzFsYKfHpEcIyRgCHVe7RMU8HDM2B6WZe1jMcOdngQy1Bv1ycbFO4/Yoo hR+855GXx+DggdScmMgP7v8KSYtwS3iIy3uAK/JTpZHK+1IhLTWXBJNHEuL2Fw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=jeZrZhdz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.77 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=jeZrZhdz; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3E361DC26 X-Spam-Score: -4.77 X-Migadu-Scanner: scn0.migadu.com X-TUID: HDfA02aRdfGc Hello, Vagrant Cascadian skribis: > Another strategy would be to reduce the overly cautious lint check: > > diff --git a/guix/lint.scm b/guix/lint.scm > index ac2e7b3841..e795c466b1 100644 > --- a/guix/lint.scm > +++ b/guix/lint.scm > @@ -957,7 +957,7 @@ (define (starts-with-package-name? file-name) > > ;; Check whether we're reaching tar's maximum file name length. > (let ((prefix (string-length (%distro-directory))) > - (margin (string-length "guix-2.0.0rc3-10000-1234567890/")) > + (margin (string-length "guix-2.0.0rc3-10000-12345678/")) > (max 99)) > (filter-map (match-lambda > ((? string? patch) > > > That leaves only two packages on master in violation of the lint check, > and those are both updatable directly on master, and "make dist" still > works with those two packages as they are, in my experience. > > I think that's fairly safe to do, actually, as "make dist" on > core-updates-frozen currently produces a tarball prefixed with: > > guix-1.3.0.10380-fe257/ > > If guix keeps bumping it's version into the double-digits, an > rc-version, and it surpasses 99999 commits, and an extra character for > the git commit hash, this still leaves considerable wiggle-room: > > guix-10.0.0rc0-123456-abcde0/ > vs. > guix-2.0.0rc3-10000-12345678/ > > So, I guess I'm leaning towards making the guix lint check a little more > lenient. > > Thoughts? That sounds even better, I=E2=80=99m all for it (changing (guix lint) + fix= ing the two remaining issues)! Ludo=E2=80=99.