From: Thiago Jung Bauermann <bauermann@kolabnow.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: guix-devel@gnu.org
Subject: Reviewing the diff when updating a package?
Date: Fri, 01 Apr 2022 22:59:40 -0300 [thread overview]
Message-ID: <87y20ogqjl.fsf@kolabnow.com> (raw)
In-Reply-To: <0035734f12073a2f50d41641f66dacc35e2e6a2c.camel@telenet.be>
Hello Maxime,
Maxime Devos <maximedevos@telenet.be> writes:
> Patch is not yet ready (I'm looking at the source code diff for
> anything ‘suspicious’), just reserving a bug number and avoiding double
> work. Will send an actual patch later.
I hope you don't mind me asking what do you mean by ‘suspicious’?
Is it reviewing the code for security concerns?
I ask because I've wondered sometimes whether contributors updating a
package to a new version should review the new source code.
--
Thanks
Thiago
next parent reply other threads:[~2022-04-02 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0035734f12073a2f50d41641f66dacc35e2e6a2c.camel@telenet.be>
2022-04-02 1:59 ` Thiago Jung Bauermann [this message]
2022-04-02 8:27 ` Reviewing the diff when updating a package? Maxime Devos
2022-04-02 21:48 ` Thiago Jung Bauermann
2022-04-05 12:34 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y20ogqjl.fsf@kolabnow.com \
--to=bauermann@kolabnow.com \
--cc=guix-devel@gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).