From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kAY6NFK6OGMvaAAAbAwnHQ (envelope-from ) for ; Sun, 02 Oct 2022 00:08:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SKxKNFK6OGMVIQAA9RJhRA (envelope-from ) for ; Sun, 02 Oct 2022 00:08:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 804382FC1D for ; Sun, 2 Oct 2022 00:08:18 +0200 (CEST) Received: from localhost ([::1]:33580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oekef-0006wS-OR for larch@yhetil.org; Sat, 01 Oct 2022 18:08:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oekd9-0004eQ-Ao for guix-devel@gnu.org; Sat, 01 Oct 2022 18:06:43 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:46253) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oekd7-0001Jz-BA; Sat, 01 Oct 2022 18:06:43 -0400 Received: from localhost (82-132-235-153.dab.02.net [82.132.235.153]) by mira.cbaines.net (Postfix) with ESMTPSA id C6A4027BBE9; Sat, 1 Oct 2022 23:06:34 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id d93ed7bb; Sat, 1 Oct 2022 22:06:32 +0000 (UTC) References: <87mtbc3g5e.fsf@cbaines.net> <87sfkneqmm.fsf@cbaines.net> <878rlzec5e.fsf@gnu.org> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Subject: Re: Progress with automating testing of patches Date: Sat, 01 Oct 2022 22:58:09 +0100 In-reply-to: <878rlzec5e.fsf@gnu.org> Message-ID: <87y1tzjj15.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664662098; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=BowfMskQ68ob7Wb4fI60q3n5jR1RjaYK7EbVGuxiLxA=; b=Me/KkjLQfhsoz8bbj7adpOGT5QWmjl/yRuRmNu9ICp7FpoN/1V/MePWiSUJnMMYgoTz2J9 HAzjr4bM9n7d99334TRGcYa5Nl3Mwn+9geA9ZObonbFIbgLQcKESgM2gjfXDbCaAJHXCJw 9+DbNJrGxHRzadaECpfAUPb5fuqX1FKImh9JKI9e4Tqv2ve53Ew0GCwkSKXZh7KlIkPndx nK3RanVah5JhjIE0npnbafFI6BFqecIozid791g2CpIBnwUDb42i9+vl7EvBTKTIBoVCaZ bdYlzI2coqaF3D8TBrxY46gzq+up3ruMjdhwukYroO42Ic0WLUYJuxjhAPLvxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664662098; a=rsa-sha256; cv=none; b=FS7Cmyc9B/Je1aN8r3/F+1kC0fWX5fhT+odFycWhl3JrPgnBtRIInczZtVpgwZzFOD5hTe UWB5ZgNDjo386icSOvk1PFrDjGOgkC0BtKXzoU/U/ckqV/MPdopKdUvBvVuPyal4qo5HcM uKYputPoMOkJ7+u+XgMTWsCzCvstktLcfxOBCKCbGAJe/+P/4uRof7VtvLwwbj8F52Zq7O yBNmAcqyCHTl8TWC1bAyl28e9Ew/+EzKgI1w3s+7gigOZUVOkAz0uzcW3I16iZM+3t057M zEquY2LHG3w1Oe1W/9JhNRGV28FQWLAsYyUJ9q69qSlzwhsYrPwAmmzk7x5uHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.24 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 804382FC1D X-Spam-Score: -3.24 X-Migadu-Scanner: scn1.migadu.com X-TUID: Ks1SwJwhkDrf --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > I wonder if it=E2=80=99s due to recent changes since I last looked, but I= =E2=80=99m a > bit confused by the numbers in this example: > > https://qa.guix.gnu.org/issue/58186 > > The numbers before/after patches don=E2=80=99t match and the lint warning= s (nice > addition!) appear to unrelated to the patch at hand. > > Any idea what=E2=80=99s going on? I've had an initial look. One important clue is that the basis of the comparison [1] differs between data.qa.guix.gnu.org and data.guix.gnu.org [2]. The package number differs for example. 1: https://data.qa.guix.gnu.org/revision/e6777cfa5eb5e9c36eaf7810b42cac0fbc= aa367c 2: https://data.guix.gnu.org/revision/e6777cfa5eb5e9c36eaf7810b42cac0fbcaa3= 67c That shouldn't happen, one revision of Guix should have the same number of packages regardless of what server looked at it. This being wrong explains the bad data on qa.guix.gnu.org, since the comparison being done by data.qa.guix.gnu.org is based on bad data. This reminds me of [3] where data.guix.gnu.org processed a revision and somehow got things wrong. 3: https://lists.gnu.org/archive/html/guix-devel/2021-09/msg00192.html I'll try investigating this further when I have more time, there should be locking in place so that even when multiple jobs are being processed at the same time, only one job at a time is able to call latest-channel-instances, so I don't currently have a theory as to how this goes wrong. I think I added more logging off the back of the previous issue, so maybe I'll be able to get further this time. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmM4ueZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfaOg//ZKpoUPUqmjmLy5m3vn6uBeQzgH9g7YZv xpQvlPHPugrVguHjU8qswtSkmXlZ07bMsBZeM5jlbLGFvSt2WQMjEFGmYv228s+8 gQs/qXOOY9XmaaUVfVFupnb3eaw4kuieLanSHQ9wx92SIsomfAkfv9zrx94QqAQj cCXh9yDfDUXWDyzGF6HaQf4r/jHhhkqs/BgWou4tTuyuTla70L4BY8JH1RWKQC/i oxft4h4VvY7Q4ylwEndKm1rrQzuxFVdtgMtad3n5PH73Mzyk0a3VEnqF1Eymwd5y ruAL/qsqZZ+j0neG82v4Tn/yQgGcStHLQ1tQPknKkoMxQhEAmv5G4G07QJr+sx9i 8S44dn1EmhDthDaN9KgwoAXwMWyGAqXGZA2LU5XokrehJ8dJPZE4wO6iZpGUISJT gavdkA95sESiirt9wtlDzb85h70+kPRkGfqVzybgrHtBrw2DEYYMEqctomhVfZz8 jov/sKnByq3NWDBYE97dyPIK8uue3CKsZqqFb4mkl6mZegFPerP6PGxiXnjGZ6c5 Do0zB6BZOXM+gC50TKNr1eGOexUe459so7cHllZbxpk5yrT6DcT3c1fR8Ay74zRD LbyTJlx8znJnQhtu+u5NqS259UPnzOS/c0SrSvz14XC508lNi8fjP9sGncahtwZ5 GWiYCREvQmU= =0mUb -----END PGP SIGNATURE----- --=-=-=--