unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jelle Licht <jlicht@fsfe.org>
To: Philip McGrath <philip@philipmcgrath.com>, guix-devel@gnu.org
Subject: Re: Potential removal of unmaintained node-openzwave-shared
Date: Thu, 30 Mar 2023 14:37:43 +0200	[thread overview]
Message-ID: <87y1nebejs.fsf@fsfe.org> (raw)
In-Reply-To: <28580fa6-3933-4a01-96ba-f06cc69f5943@app.fastmail.com>


Hi,

"Philip McGrath" <philip@philipmcgrath.com> writes:

> Hi,
>
> On Wed, Mar 22, 2023, at 8:08 AM, Jelle Licht wrote:
>> Hey guix,
>>
>> In getting `Node.js' updated to a more recent LTS version[0], I found
>> out that node-openzwave-shared no longer builds with modern versions of
>> node [1]; random people on the Internet seem to indicate that
>> the hip new thing is Z-Wave JS [2].
>>
>> Long story short, what is our de facto policy here?
>>
>> 1) Keep around a copy of Node 14 and all node-openzwave-shared deps,
>>    even after the End Of Life of 2023-04-30
>> 2) Remove node-openzwave-shared, and move to Node 18 whenever possible
>>    without this package.
>> 3) Patch node-openzwave-shared' so it builds with newer versions of
>>    Node, and move to Node 18.
>> 4) Remove node-openzwave-shared, move to Node 18, package the relevant
>>    parts of Z-Wave JS.
>>
>> I don't have the time nor means for anything but option 2) myself, so if
>> consensus deems any of the other options a better way forward,
>> volunteers are invited to apply :-)
>>
>> [0]: https://issues.guix.gnu.org/59188
>> [1]: https://github.com/OpenZWave/node-openzwave-shared/issues/398
>> [2]: https://github.com/zwave-js?type=source
>
> I added this package, so I have some interest in trying options 3 or 4, but I don't think this should block Node 18 in any case.
>
> Is there a log message for the build failure somewhere? I don't see any details at [2], and I'm a bit surprised by the failure.

I've played around with it, and was able to get it to compile (and pass
tests?) in v6 of the node patch series:

https://issues.guix.gnu.org/59188#83

Could you see if that works for your workflows?

Thanks!
- Jelle



      reply	other threads:[~2023-03-30 12:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 12:08 Potential removal of unmaintained node-openzwave-shared Jelle Licht
2023-03-22 18:07 ` Maxim Cournoyer
2023-03-25 16:58 ` Philip McGrath
2023-03-30 12:37   ` Jelle Licht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1nebejs.fsf@fsfe.org \
    --to=jlicht@fsfe.org \
    --cc=guix-devel@gnu.org \
    --cc=philip@philipmcgrath.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).