From: Vagrant Cascadian <vagrant@debian.org>
To: Giovanni Biscuolo <g@xelera.eu>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel@gnu.org, "Ludovic Courtès" <ludo@gnu.org>
Subject: Re: [workflow] Automatically close bug report when a patch is committed
Date: Thu, 07 Sep 2023 09:12:29 -0700 [thread overview]
Message-ID: <87y1hikln6.fsf@wireframe> (raw)
In-Reply-To: <87jzt2feq6.fsf@xelera.eu>
[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]
On 2023-09-07, Giovanni Biscuolo wrote:
> Hi Maxim and Ludovic,
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>> Giovanni Biscuolo <g@xelera.eu> writes:
..
>>> When I asket I though the best way would be to scan for a string like
>>> "Close #<bug-number>" in the commit message (the committer should add
>>> such a string) but probably this can be avoided: the bug can be closed
>>> when a patch is committed to one of the listed official brances (master,
>>> core-updates, etc.)
>>
>> You mean by simply matching the subject? Maybe that could work.
>
> Thinking twice maybe it's better to add a "Close: #<bug>" to the commit
> message.
Sooooo... I maintain the guix package in Debian, and want to make sure
that whatever bug-closing indicator guix upstream uses, does not end up
triggering when I push new upstream versions to salsa.debian.org ... and
start incorrectly marking incorrect bug numbers on bugs.debian.org that
were meant for debbugs.gnu.org.
Currently that is:
https://salsa.debian.org/salsa/salsa-webhook/-/blob/997412ad4b1d89fd3227d5409471bdf71abcf863/helpers/bugs.rb#L19
SCAN_BUGS = /Closes:\s+(?:Bug)?#(?:(\d{4,8})\b)(?:,?\s*(?:Bug)?#(?:(\d{4,8})\b))*/i
"Close: #<bug>" is a bit nervously close; I could see a stray typo of an
extra "s" triggering the occasional very annoying problem.
I am much more comfortable with the "Fixes" convention of:
Fixes: https://issues.guix.gnu.org/NNN
So, while I cannot insist here... I can plead a bit... and a namespaced
URL is kind of better in some ways anyways. :)
live well,
vagrant
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2023-09-07 16:13 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 8:28 [workflow] Automatically close bug report when a patch is committed Giovanni Biscuolo
2023-09-06 9:45 ` Christopher Baines
2023-09-07 9:38 ` [workflow] Triaging issues (was Automatically close bug report when a patch is committed) Giovanni Biscuolo
2023-09-07 15:41 ` Vagrant Cascadian
2023-09-11 7:37 ` Giovanni Biscuolo
2023-09-11 15:29 ` Simon Tournier
2023-09-11 17:08 ` Giovanni Biscuolo
2023-09-06 16:14 ` [workflow] Automatically close bug report when a patch is committed Maxim Cournoyer
2023-09-07 0:23 ` Simon Tournier
2023-09-07 2:01 ` Maxim Cournoyer
2023-09-07 9:58 ` Simon Tournier
2023-09-09 23:43 ` Maxim Cournoyer
2023-09-07 13:11 ` Giovanni Biscuolo
2023-09-09 23:39 ` Maxim Cournoyer
2023-09-11 7:53 ` Giovanni Biscuolo
2023-09-11 14:01 ` Maxim Cournoyer
2023-09-11 17:10 ` Giovanni Biscuolo
2023-09-07 11:08 ` Giovanni Biscuolo
2023-09-07 11:58 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-07 13:09 ` Maxim Cournoyer
2023-09-07 15:52 ` Vagrant Cascadian
2023-09-09 23:50 ` Maxim Cournoyer
2023-09-11 11:00 ` Simon Tournier
2023-09-11 13:46 ` Maxim Cournoyer
2023-09-11 14:11 ` Simon Tournier
2023-09-11 15:33 ` Maxim Cournoyer
2023-09-13 2:46 ` Vagrant Cascadian
2023-09-13 15:49 ` Maxim Cournoyer
2023-09-14 16:30 ` Vagrant Cascadian
2023-09-14 18:02 ` Maxim Cournoyer
2023-09-07 13:19 ` Giovanni Biscuolo
2023-09-07 10:40 ` Giovanni Biscuolo
2023-09-07 13:49 ` Giovanni Biscuolo
2023-09-27 14:36 ` Christopher Baines
2023-09-07 16:12 ` Vagrant Cascadian [this message]
2023-09-07 16:28 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-09-09 23:59 ` Liliana Marie Prikler
2023-09-11 8:09 ` Giovanni Biscuolo
2023-09-11 13:59 ` Maxim Cournoyer
2023-09-11 17:55 ` Liliana Marie Prikler
2023-09-11 18:36 ` Maxim Cournoyer
2023-09-11 18:51 ` Liliana Marie Prikler
2023-09-11 20:41 ` Maxim Cournoyer
2023-09-12 13:55 ` Giovanni Biscuolo
2023-09-13 15:19 ` Maxim Cournoyer
2023-09-14 9:42 ` Giovanni Biscuolo
2023-09-14 16:58 ` Liliana Marie Prikler
2023-09-12 17:03 ` Liliana Marie Prikler
2023-09-13 9:37 ` Giovanni Biscuolo
2023-09-13 15:27 ` Maxim Cournoyer
2023-09-13 19:14 ` Liliana Marie Prikler
2023-09-13 22:12 ` Simon Tournier
2023-09-14 3:00 ` Maxim Cournoyer
2023-09-14 10:48 ` Giovanni Biscuolo
2023-09-15 21:46 ` Vagrant Cascadian
2023-09-19 16:41 ` Giovanni Biscuolo
2023-09-14 10:27 ` Giovanni Biscuolo
2023-09-14 12:25 ` Simon Tournier
2023-09-15 7:16 ` Giovanni Biscuolo
2023-09-15 9:03 ` Simon Tournier
2023-09-15 14:37 ` The already complicated (complex?) process for contributing Giovanni Biscuolo
2023-09-15 16:43 ` Simon Tournier
2023-09-16 7:33 ` Giovanni Biscuolo
2023-09-16 8:33 ` Simon Tournier
2023-09-14 7:20 ` [workflow] Automatically close bug report when a patch is committed Andreas Enge
2023-09-14 10:25 ` Giovanni Biscuolo
2023-09-14 22:51 ` Vagrant Cascadian
2023-09-15 4:23 ` Liliana Marie Prikler
2023-09-15 21:30 ` Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1hikln6.fsf@wireframe \
--to=vagrant@debian.org \
--cc=g@xelera.eu \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).