Re: [PATCH] gnu: Add libpetsc

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <ericbavier@gmail.com> skribis:

> From 73b22ecbc690a2acde4a5cd8a7f6f9b1f220bfe1 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Wed, 30 Apr 2014 14:01:43 -0500
> Subject: [PATCH] gnu: Add libpetsc
>
> * gnu/packages/maths.scm (libpetsc): New variable.
>   (libpetsc-complex): New variable.
> * gnu/packages/patches/petsc-fix-threadcomm.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.

[...]

> +(define-public libpetsc
> +  (package
> +    (name "libpetsc")

I think this should be “petsc”, as it’s the upstream name and commonly
used AFAIK.  WDYT?

[...]

> +         ;; Try to keep installed files from leaking build directory paths.
> +         ;; Fortran modules will have references to the build directory
> +         ;; because cmake passes absolute path names to the compiler.

Rather “directory names” and “absolute file names” (info "(standards)
GNU Manuals").

(This CMake story is terrible, BTW.)

> +(define-public libpetsc-complex
> +  (package (inherit libpetsc)
> +    (name "libpetsc-complex")

Likewise, “petsc-complex”?

> +++ b/gnu/packages/patches/petsc-fix-threadcomm.patch

Please add a comment at the beginning of the patch saying what it does
and whether it’s available upstream.

Thanks,
Ludo’.