From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add busybox.
Date: Fri, 13 Jun 2014 15:32:05 +0200 [thread overview]
Message-ID: <87wqclj5pm.fsf@gnu.org> (raw)
In-Reply-To: <1402664042-14123-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Fri, 13 Jun 2014 14:54:01 +0200")
Overall looks good to me. Minor improvements suggested below.
John Darrington <jmd@gnu.org> skribis:
> * gnu/packages/busybox.scm: New file
> * gnu-system.am: Add gnu/packages/busybox.scm
No indentation needed.
Phrases/sentences started with a capital letter must end with a period.
> + (lambda _
> + (begin
No need for ‘begin’ here.
> + ;; There is no /usr/bin - replace it with /gnu/store
> + (substitute* "testsuite/cpio.tests"
> + (("/usr/bin") "/gnu/store"))
> +
> + (substitute* "testsuite/cpio.tests"
> + (("usr") "gnu"))
Both clauses can go in a single ‘substitute*’.
> + ;; This test cannot possibly pass
> + ;; It is trying to test that "which ls" returns "/bin/ls" when PATH is not set.
> + ;; However, this relies on /bin/ls existing. Which it does not in guix
Periods & capitalization.
> + (native-inputs `(("perl" ,perl) ; Needed to generate the man pages (pod2man)
Lower-case.
> + ;; The following are needed by the tests
Period.
Thanks!
Ludo’.
prev parent reply other threads:[~2014-06-13 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 12:54 [PATCH] gnu: Add busybox John Darrington
2014-06-13 13:32 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqclj5pm.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).