From: David Thompson <dthompson2@worcester.edu>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add freeimage.
Date: Sun, 02 Nov 2014 12:55:01 -0500 [thread overview]
Message-ID: <87wq7dv66i.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20141102174652.GD6865@debian>
Andreas Enge <andreas@enge.fr> writes:
> On Sat, Nov 01, 2014 at 01:21:55PM -0400, David Thompson wrote:
>> + '(#:phases (alist-replace
>> + 'unpack
>> + (lambda* (#:key source #:allow-other-keys)
>> + (and (zero? (system* "unzip" source))
>> + (chdir "FreeImage")))
>> + (alist-delete
>> + 'configure
>> + (alist-cons-before
>> + 'build 'patch-makefile
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (substitute* "Makefile.gnu"
>> + (("/usr") (assoc-ref outputs "out"))
>> + (("-o root -g root") "")))
>> + %standard-phases)))
>
> I think that instead of adding patch-makefile before build, I would let it
> replace configure. But this is just a matter of taste, so please do as you
> please.
That's a fair point, though I have already pushed. Thanks, anyhow. :)
--
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate
next prev parent reply other threads:[~2014-11-02 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 15:48 [PATCH] gnu: Add freeimage David Thompson
2014-11-01 16:59 ` Andreas Enge
2014-11-01 17:21 ` David Thompson
2014-11-02 17:26 ` Ludovic Courtès
2014-11-02 17:35 ` David Thompson
2014-11-02 17:46 ` Andreas Enge
2014-11-02 17:55 ` David Thompson [this message]
2014-11-02 21:10 ` Andreas Enge
2014-11-02 21:38 ` David Thompson
2014-11-03 9:00 ` Ludovic Courtès
2014-11-03 9:29 ` Andreas Enge
2014-11-03 20:28 ` Ludovic Courtès
2014-11-03 23:29 ` David Thompson
2014-11-04 9:50 ` Ludovic Courtès
2014-11-05 3:12 ` David Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq7dv66i.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me \
--to=dthompson2@worcester.edu \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).