From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/4] import: Factorize utility functions.
Date: Fri, 09 Jan 2015 14:36:41 +0100 [thread overview]
Message-ID: <87wq4w5b4m.fsf@gnu.org> (raw)
In-Reply-To: <1420753555-15767-2-git-send-email-bavier@member.fsf.org> (Eric Bavier's message of "Thu, 8 Jan 2015 15:45:52 -0600")
Eric Bavier <ericbavier@gmail.com> skribis:
> * guix/import/pypi.scm (hash-table->alist, flatten, assoc-ref*,
> url-fetch, json-fetch): Pull functions from here and...
> * guix/import/gnu.scm (file-sha256): here out into...
> * guix/import/utils.scm: Here, and...
> * guix/import/json.scm: Here. New file.
> * Makefile.am (MODULE)[guile-json]: Add it.
Should be:
* Makefile.am (MODULES)[HAVE_GUILE_JSON]: Add it.
> * tests/pypi.scm (pypi->guix-package): Update mock module reference.
LGTM, but could you move ‘file-sha256’ to (guix hash) instead, below
‘port-sha256’?
> --- a/guix/import/gnu.scm
> +++ b/guix/import/gnu.scm
> @@ -1,4 +1,4 @@
> -;;; GNU Guix --- Functional package management for GNU
> +;; GNU Guix --- Functional package management for GNU
Typo.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-01-09 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 21:45 [PATCH 1/4] import: gnu: Propagate the key-download argument Eric Bavier
2015-01-08 21:45 ` [PATCH 2/4] import: Factorize utility functions Eric Bavier
2015-01-09 13:36 ` Ludovic Courtès [this message]
2015-01-08 21:45 ` [PATCH 3/4] tests: import: Factorize utility function Eric Bavier
2015-01-09 13:37 ` Ludovic Courtès
2015-01-08 21:45 ` [PATCH 4/4] import: Add CPAN importer Eric Bavier
2015-01-09 13:41 ` Ludovic Courtès
2015-01-09 13:31 ` [PATCH 1/4] import: gnu: Propagate the key-download argument Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq4w5b4m.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=ericbavier@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).