From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Various icedtea6 patches
Date: Thu, 19 Mar 2015 10:07:26 +0100 [thread overview]
Message-ID: <87wq2d5p9t.fsf@gnu.org> (raw)
In-Reply-To: <idjsid3u5hh.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Tue, 17 Mar 2015 14:18:50 +0100")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> From 3bc3dd46ebec97acf424bbc8b3026ee23fdafa19 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 10 Mar 2015 13:56:55 +0100
> Subject: [PATCH 1/5] gnu: icedtea6: patch ant shebang in unpack phase
>
> * gnu/packages/java.scm (icedtea6)[arguments]: patch bootstrap ant in the
> `unpack' phase instead of `patch-paths'.
OK.
> From 0d8261286f0d4a14b65359c7f23276f9d166c49e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 10 Mar 2015 14:00:55 +0100
> Subject: [PATCH 2/5] gnu: icedtea6: patch hardcoded objcopy path.
>
> * gnu/packages/java.scm (icedtea6)[arguments]: patch Makefile to override
> DEF_OBJCOPY variable definition.
OK.
> From 9c9ef4fde4003a3bc9af73462552edde5d46c909 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 10 Mar 2015 14:05:48 +0100
> Subject: [PATCH 3/5] gnu: icedtea6: patch patches in separate build phase.
>
> * gnu/packages/java.scm (icedtea6)[arguments]: patch patches in a separate
> build phase `patch-patches' instead of `patch-paths'.
Is it really patches that are being patched? Not obvious from a quick
look.
Anyway, maybe “Move patching from ‘patch-paths’ to new ‘patch-patches’
phase.”
> From 7b4a5b8861de9f8f940d8bf60e225fcafbbb2b1c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 10 Mar 2015 17:03:44 +0100
> Subject: [PATCH 4/5] gnu: icedtea6: rename build phase `set-paths'
>
> * gnu/packages/java.scm (icedtea6)[arguments]: Avoid overriding standard
> `set-paths' phase by renaming new phase to `set-additional-paths'.
Just “Rename ‘set-paths’ phase to ‘set-additional-paths’.”
However the removal of CC and LD_LIBRARY_PATH should be made a separate
patch.
> From 0c2f26564987721c7ec112cfa0d8d714ef4fda01 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Tue, 17 Mar 2015 14:12:14 +0100
> Subject: [PATCH 5/5] gnu: icedtea6: remove commented substitution.
>
> * gnu/packages/java.scm (icedtea6): Remove commented substitution.
OK.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-03-19 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 13:18 [PATCH] Various icedtea6 patches Ricardo Wurmus
2015-03-19 9:07 ` Ludovic Courtès [this message]
2015-03-19 13:05 ` Ricardo Wurmus
2015-03-20 20:17 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq2d5p9t.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).