From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Remove unused patchelf inputs Date: Mon, 23 Mar 2015 10:22:30 +0100 Message-ID: <87wq28kqzt.fsf@gnu.org> References: <87bnjk4au1.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZyZC-0005Wf-27 for guix-devel@gnu.org; Mon, 23 Mar 2015 05:22:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZyZ7-0007fr-11 for guix-devel@gnu.org; Mon, 23 Mar 2015 05:22:38 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZyZ6-0007fm-UJ for guix-devel@gnu.org; Mon, 23 Mar 2015 05:22:32 -0400 In-Reply-To: <87bnjk4au1.fsf@netris.org> (Mark H. Weaver's message of "Mon, 23 Mar 2015 00:05:58 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org Mark H Weaver skribis: > I was puzzled to find three occurrences of 'patchelf' in packages that > do not appear to use it. The packages build successfully with this > patch, and I don't see any missing rpaths in the resulting outputs. I > also don't see anything that would use 'patchelf' in those packages. > > Am I missing something? This patch looks good to me. For libssh, for instance, =E2=80=98patchelf= =E2=80=99 is a leftover from a time when it was used to fiddle with the RUNPATH of libssh (commit deed349.) Same for lapack (commit 57e544e8.) This special RUNPATH-handling code was removed by 06ed598. Thank you, Ludo=E2=80=99.