From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: guile-static: Use Linux syscalls only on Linux
	systems.
Date: Sun, 24 May 2015 00:37:55 +0200
Message-ID: <87wpzyc43g.fsf@gnu.org>
References: <CAFtzXzNj8-ZzYf=y_yJNY0bodkqze0BMY8L4QX+Os2a8pvbCEg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YwI3O-00071F-6O
	for Guix-devel@gnu.org; Sat, 23 May 2015 18:38:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YwI3K-00055K-Un
	for Guix-devel@gnu.org; Sat, 23 May 2015 18:38:02 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46674)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YwI3K-00055F-RO
	for Guix-devel@gnu.org; Sat, 23 May 2015 18:37:58 -0400
In-Reply-To: <CAFtzXzNj8-ZzYf=y_yJNY0bodkqze0BMY8L4QX+Os2a8pvbCEg@mail.gmail.com>
	(Manolis Ragkousis's message of "Sat, 23 May 2015 22:13:49 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>

Manolis Ragkousis <manolis837@gmail.com> skribis:

> Because of "guile-linux-syscalls.patch" current form, I end up getting
> no <sys/mount.h> found when Hurd it targeted.
> I added #ifdef __LINUX__ so the patch will be used only on Linux systems.
>
> From ac6bab86b2ae5509e29aea15125f31ea18c0015f Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sat, 23 May 2015 22:10:34 +0300
> Subject: [PATCH] gnu: guile-static: Use Linux syscalls only on Linux syst=
ems.
>
> * gnu/packages/patches/guile-linux-syscalls.patch: Use Linux
>   syscalls only on Linux systems.

This must be:

  #ifdef __linux__

Lower-case.  I don=E2=80=99t think __LINUX__ is ever defined.  (See the out=
put
of =E2=80=9Ccpp -dM /dev/null|grep -i linux=E2=80=9D.)

Also, s/Linux systems/Linux-based systems/

OK with these changes.

(This change is acceptable because so far this patch is used only for
the initrd Guile, and there=E2=80=99s no initrd on GNU/Hurd.

Note that eventually, when you start porting GuixSD to GNU/Hurd, you=E2=80=
=99ll
notice that we rely on libc=E2=80=99s =E2=80=98mount=E2=80=99 and =E2=80=98=
umount=E2=80=99 functions.  These are
currently not implemented on GNU/Hurd, but it=E2=80=99s =E2=80=9Cjust a mat=
ter=E2=80=9D of
implementing them in terms of =E2=80=98file_set_translator=E2=80=99 & co., =
which is
mostly done in the Hurd=E2=80=99s utils/{,u}mount.c.)

Thanks!

Ludo=E2=80=99.