From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: guile-static: Use Linux syscalls only on Linux systems.
Date: Sun, 24 May 2015 00:37:55 +0200 [thread overview]
Message-ID: <87wpzyc43g.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzNj8-ZzYf=y_yJNY0bodkqze0BMY8L4QX+Os2a8pvbCEg@mail.gmail.com> (Manolis Ragkousis's message of "Sat, 23 May 2015 22:13:49 +0300")
Manolis Ragkousis <manolis837@gmail.com> skribis:
> Because of "guile-linux-syscalls.patch" current form, I end up getting
> no <sys/mount.h> found when Hurd it targeted.
> I added #ifdef __LINUX__ so the patch will be used only on Linux systems.
>
> From ac6bab86b2ae5509e29aea15125f31ea18c0015f Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sat, 23 May 2015 22:10:34 +0300
> Subject: [PATCH] gnu: guile-static: Use Linux syscalls only on Linux systems.
>
> * gnu/packages/patches/guile-linux-syscalls.patch: Use Linux
> syscalls only on Linux systems.
This must be:
#ifdef __linux__
Lower-case. I don’t think __LINUX__ is ever defined. (See the output
of “cpp -dM /dev/null|grep -i linux”.)
Also, s/Linux systems/Linux-based systems/
OK with these changes.
(This change is acceptable because so far this patch is used only for
the initrd Guile, and there’s no initrd on GNU/Hurd.
Note that eventually, when you start porting GuixSD to GNU/Hurd, you’ll
notice that we rely on libc’s ‘mount’ and ‘umount’ functions. These are
currently not implemented on GNU/Hurd, but it’s “just a matter” of
implementing them in terms of ‘file_set_translator’ & co., which is
mostly done in the Hurd’s utils/{,u}mount.c.)
Thanks!
Ludo’.
next prev parent reply other threads:[~2015-05-23 22:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 19:13 [PATCH] gnu: guile-static: Use Linux syscalls only on Linux systems Manolis Ragkousis
2015-05-23 22:37 ` Ludovic Courtès [this message]
2015-06-09 19:23 ` Manolis Ragkousis
2015-06-09 20:01 ` Manolis Ragkousis
2015-06-09 20:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpzyc43g.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).