Re: [PATCH] gnu: guix: Set 'guix-dot-program' emacs variable.

[ludo@gnu.org (Ludovic Courtès)]

Alex Kost <alezost@gmail.com> skribis:

> From dd793147718cb18766268c8aad50d24b88ffe6b6 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Fri, 16 Oct 2015 20:34:32 +0300
> Subject: [PATCH 1/2] build: Set DOT_USER_PROGRAM for Emacs interface.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> Suggested by Ludovic Courtès <ludo@gnu.org>.
>
> * configure.ac: Set DOT_USER_PROGRAM variable.
> * emacs/guix-config.el.in (guix-config-dot-program): New constant.
> * emacs/guix-external.el (guix-dot-program): Use it.

[...]

> +(defconst guix-config-dot-program "@DOT_USER_PROGRAM@"
> +  "Name of the 'dot' executable defined at the configure time.")

“at configure time”

The docstring should mention that it can be the empty string.
Alternately, ‘configure’ could set DOT_USER_PROGRAM to “dot” when it’s
not found, which I think is ever preferable.  WDYT?

> +(defcustom guix-dot-program
> +  (if (string= "" guix-config-dot-program)
> +      (executable-find "dot")
> +    guix-config-dot-program)

Thus here we’d be checking whether ‘guix-config-dot-program’ is an
absolute file name.

> From be9e01b3c2d6ca9f47c5bdac38effe7a7bb707dc Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Fri, 16 Oct 2015 20:48:24 +0300
> Subject: [PATCH 2/2] emacs: config: Use "emacs-config-" prefix for constants.
>
> * emacs/guix-config.el.in (guix-emacs-interface-directory,
>   guix-state-directory): Rename to ...
>   (guix-config-emacs-interface-directory, guix-config-state-directory):
>   ...this.
>   (guix-config-guile-program): New constant.
>   (guix-guile-program): Move to ...
> * emacs/guix-external.el (guix-guile-program): ...here.  Make it a
>   'defcustom'.
> * emacs/guix-profiles.el (guix-default-profile): Use
>   'guix-config-state-directory'.
> * emacs/guix-backend.el (guix-load-path): Use
>   'guix-config-emacs-interface-directory'.

OK!

Thanks,
Ludo’.