From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data. Date: Thu, 10 Dec 2015 10:42:14 +0100 Message-ID: <87wpsmiqrt.fsf@gnu.org> References: <87fuzcsvt1.fsf@gnu.org> <87wpsnsp8x.fsf@gnu.org> <87y4d31p24.fsf@gnu.org> <87zixjl4w8.fsf@gnu.org> <87poyfhuyb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6xjw-0004Ow-OD for guix-devel@gnu.org; Thu, 10 Dec 2015 04:42:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6xjs-0004Kl-HV for guix-devel@gnu.org; Thu, 10 Dec 2015 04:42:20 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6xjs-0004Kb-E4 for guix-devel@gnu.org; Thu, 10 Dec 2015 04:42:16 -0500 In-Reply-To: <87poyfhuyb.fsf@gnu.org> (Mathieu Lirzin's message of "Thu, 10 Dec 2015 03:57:16 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin Cc: guix-devel Mathieu Lirzin skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Mathieu Lirzin skribis: > [...] >>> + (native-search-paths >>> + (list (search-path-specification >>> + (variable "TERMINFO_DIRS") >>> + (files '("share/terminfo"))))) >> >> This should be in the ncurses package itself, since it is =E2=80=9Cowned= =E2=80=9D by >> ncurses, not rxvt. >> >> However, there=E2=80=99s the limitation that, currently, --search-paths >> advertises the variables of things that are explicitly in the profile. >> Ncurses is usually not in the profile; it is a dependency of something >> that is in the profile. Thus, people wouldn=E2=80=99t see anything about >> TERMINFO_DIRS in practice (we have the same problem with OpenSSL, >> GStreamer, and other librairies that have associated variables.) >> >> Long story short, I would avoid adding this =E2=80=98native-search-paths= =E2=80=99 here, >> but I=E2=80=99m OK with it since that would make the thing usable, provi= ded >> there=E2=80=99s a big FIXME in there. >> >> WDYT? > > It makes sense. Since it is quite complicated, what about creating a > bug report explaining the problem and make the comment refer to it like > this: > > ;; FIXME: This is not located in `ncurses' for usability reasons. See > ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3DXXXXX > > WDYT? Can you take care of creating the bug report or propose an > appropriate FIXME comment? I don't feel up to explaining this myself. Good idea. It=E2=80=99s at . Thanks, Ludo=E2=80=99.