From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/4] gnu: talloc: Update to 2.1.5.
Date: Thu, 17 Dec 2015 23:47:42 +0100 [thread overview]
Message-ID: <87wpscelpt.fsf@gnu.org> (raw)
In-Reply-To: <1450153322-26172-1-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Tue, 15 Dec 2015 12:21:59 +0800")
宋文武 <iyzsong@gmail.com> skribis:
> * gnu/packages/samba.scm (talloc): Update to 2.1.5.
> [arguments]: Use 'modify-phases' syntax.
It uses ‘modify-phases’ and also modifies stuff in ‘wscript’, which
should be mentioned here.
It would be ideal if you could make one patch that switches to
‘modify-phases’, and the next one that upgrades and adds the ‘wscript’
change.
> + ;; test_magic_differs.sh is a broken script, skip the test.
Could you mention what makes it “broken”? :-)
Otherwise LGTM.
Besides, I wonder if we should change it to ‘waf-build-system’.
Thanks,
Ludo’.
prev parent reply other threads:[~2015-12-17 22:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 4:21 [PATCH 1/4] gnu: talloc: Update to 2.1.5 宋文武
2015-12-15 4:22 ` [PATCH 2/4] gnu: Add tevent 宋文武
2015-12-17 22:48 ` Ludovic Courtès
2015-12-15 4:22 ` [PATCH 3/4] gnu: Add ldb 宋文武
2015-12-17 22:49 ` Ludovic Courtès
2015-12-15 4:22 ` [PATCH 4/4] gnu: samba: Update to 4.3.2 宋文武
2015-12-17 22:51 ` Ludovic Courtès
2015-12-18 2:31 ` 宋文武
2015-12-21 13:39 ` Ludovic Courtès
2015-12-17 22:47 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpscelpt.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).