From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] Add package definition for GNU XaoS. Date: Mon, 21 Dec 2015 15:42:33 +0300 Message-ID: <87wps83rd2.fsf@gmail.com> References: <20151215205144.2b2ff5f1@himbaca> <20151215210203.5d2accca@himbaca> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAzne-00066A-8X for guix-devel@gnu.org; Mon, 21 Dec 2015 07:42:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aAzna-0003xL-42 for guix-devel@gnu.org; Mon, 21 Dec 2015 07:42:50 -0500 Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:33818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aAznZ-0003xH-Ru for guix-devel@gnu.org; Mon, 21 Dec 2015 07:42:46 -0500 Received: by mail-lf0-x22c.google.com with SMTP id y184so110028742lfc.1 for ; Mon, 21 Dec 2015 04:42:45 -0800 (PST) In-Reply-To: <20151215210203.5d2accca@himbaca> (Fabian Harfert's message of "Tue, 15 Dec 2015 21:02:03 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Fabian Harfert Cc: guix-devel@gnu.org Andreas Enge (2015-12-16 04:48 +0300) wrote: > Maybe it would make sense to kindly remind them to put their releases > on ftp.gnu.org. That would also allow us to be notified of updates > (which could be used as an argument). I was going to commit this patch but now I don't know: should we wait for a reply from the maintainers about updating xaos release on gnu.org? Or maybe push this patch now, and change the origin URL later (if there will be a response)? Fabian Harfert (2015-12-15 23:02 +0300) wrote: [...] > From 6687ea7c21725bdc13e368773d5c7576a43db14e Mon Sep 17 00:00:00 2001 > From: Fabian Harfert > Date: Tue, 15 Dec 2015 21:00:38 +0100 > Subject: [PATCH] Add package definition for GNU XaoS. Our convention is to use the following commit message: --8<---------------cut here---------------start------------->8--- gnu: Add xaos. * gnu/packages/maths.scm (xaos): New variable. --8<---------------cut here---------------end--------------->8--- > --- > gnu/packages/maths.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm > index 0c0f013..181809c 100644 > --- a/gnu/packages/maths.scm > +++ b/gnu/packages/maths.scm > @@ -9,6 +9,7 @@ > ;;; Copyright © 2015 Sou Bunnbu > ;;; Copyright © 2015 Mark H Weaver > ;;; Copyright © 2015 Efraim Flashner > +;;; Copyright © 2015 Fabian Harfert > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -53,6 +54,7 @@ > #:use-module (gnu packages ghostscript) > #:use-module (gnu packages glib) > #:use-module (gnu packages gtk) > + #:use-module (gnu packages image) Our (gnu packages image) module uses (gnu packages maths). I wouldn't add this circularity, I think it was better to have xaos in a separate module. But actually I don't know if it's a real issue and what our policy on such things is. I hope more experienced guix/guile people will tell if we should avoid such circularities. -- Alex