[PATCH 0/1] Move cursynth to music.scm

[PATCH 0/1] Move cursynth to music.scm

[Leo Famulari]

I think it would be better for this software synthesizer to be in
music.scm.

Thoughts?

Leo Famulari (1):
  gnu: Move cursynth to (gnu packages music).

 gnu-system.am             |  1 -
 gnu/packages/cursynth.scm | 53 -----------------------------------------------
 gnu/packages/music.scm    | 27 ++++++++++++++++++++++++
 3 files changed, 27 insertions(+), 54 deletions(-)
 delete mode 100644 gnu/packages/cursynth.scm

-- 
2.6.4

[PATCH 1/1] gnu: Move cursynth to (gnu packages music).

[Leo Famulari]

* gnu/packages/cursynth.scm: Remove.
* gnu/packages/music.scm (cursynth): New variable, from cursynth.scm.
* gnu-system.am (GNU_SYSTEM_MODULES): Remove cursynth.scm.
---
 gnu-system.am             |  1 -
 gnu/packages/cursynth.scm | 53 -----------------------------------------------
 gnu/packages/music.scm    | 27 ++++++++++++++++++++++++
 3 files changed, 27 insertions(+), 54 deletions(-)
 delete mode 100644 gnu/packages/cursynth.scm

diff --git a/gnu-system.am b/gnu-system.am
index e1874fa..8aca139 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -76,7 +76,6 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/cryptsetup.scm			\
   gnu/packages/cups.scm				\
   gnu/packages/curl.scm				\
-  gnu/packages/cursynth.scm			\
   gnu/packages/cyrus-sasl.scm			\
   gnu/packages/databases.scm			\
   gnu/packages/datamash.scm			\
diff --git a/gnu/packages/cursynth.scm b/gnu/packages/cursynth.scm
deleted file mode 100644
index 80f86da..0000000
--- a/gnu/packages/cursynth.scm
+++ /dev/null
@@ -1,53 +0,0 @@
-;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
-;;;
-;;; This file is part of GNU Guix.
-;;;
-;;; GNU Guix is free software; you can redistribute it and/or modify it
-;;; under the terms of the GNU General Public License as published by
-;;; the Free Software Foundation; either version 3 of the License, or (at
-;;; your option) any later version.
-;;;
-;;; GNU Guix is distributed in the hope that it will be useful, but
-;;; WITHOUT ANY WARRANTY; without even the implied warranty of
-;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-;;; GNU General Public License for more details.
-;;;
-;;; You should have received a copy of the GNU General Public License
-;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
-
-(define-module (gnu packages cursynth)
-  #:use-module (guix packages)
-  #:use-module (guix licenses)
-  #:use-module (guix download)
-  #:use-module (guix build-system gnu)
-  #:use-module (gnu packages)
-  #:use-module (gnu packages pkg-config)
-  #:use-module (gnu packages ncurses)
-  #:use-module (gnu packages linux))
-
-(define-public cursynth
-  (package
-    (name "cursynth")
-    (version "1.5")
-    (source
-     (origin
-      (method url-fetch)
-      (uri (string-append "mirror://gnu/cursynth/cursynth-"
-                          version ".tar.gz"))
-      (sha256
-       (base32 "1dhphsya41rv8z6yqcv9l6fwbslsds4zh1y56zizi39nd996d40v"))
-      (patches (list (search-patch "cursynth-wave-rand.patch")))))
-    (build-system gnu-build-system)
-    (native-inputs `(("pkg-config" ,pkg-config)))
-    ;; TODO: See https://github.com/iyoko/cursynth/issues/4 which currently
-    ;; prevents us from using pulseaudio
-    (inputs `(("ncurses" ,ncurses)
-              ("alsa" ,alsa-lib)))
-    (home-page "http://www.gnu.org/software/cursynth")
-    (synopsis "Polyphonic and MIDI subtractive music synthesizer using curses")
-    (description "GNU cursynth is a polyphonic synthesizer that runs
-graphically in the terminal.  It is built on a full-featured subtractive
-synthesis engine.  Notes and parameter changes may be entered via MIDI or the
-computer's keyboard.")
-    (license gpl3+)))
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 3787576..b3cdbdc 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1,4 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
 ;;;
@@ -1002,3 +1003,29 @@ synthesizer.  It offers three synthesizer engines, multitimbral and polyphonic
 synths, microtonal capabilities, custom envelopes, effects, etc.  Yoshimi
 improves on support for JACK features, such as JACK MIDI.")
     (license license:gpl2)))
+
+(define-public cursynth
+  (package
+    (name "cursynth")
+    (version "1.5")
+    (source
+     (origin
+      (method url-fetch)
+      (uri (string-append "mirror://gnu/cursynth/cursynth-"
+                          version ".tar.gz"))
+      (sha256
+       (base32 "1dhphsya41rv8z6yqcv9l6fwbslsds4zh1y56zizi39nd996d40v"))
+      (patches (list (search-patch "cursynth-wave-rand.patch")))))
+    (build-system gnu-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    ;; TODO: See https://github.com/iyoko/cursynth/issues/4 which currently
+    ;; prevents us from using pulseaudio
+    (inputs `(("ncurses" ,ncurses)
+              ("alsa" ,alsa-lib)))
+    (home-page "http://www.gnu.org/software/cursynth")
+    (synopsis "Polyphonic and MIDI subtractive music synthesizer using curses")
+    (description "GNU cursynth is a polyphonic synthesizer that runs
+graphically in the terminal.  It is built on a full-featured subtractive
+synthesis engine.  Notes and parameter changes may be entered via MIDI or the
+computer's keyboard.")
+    (license license:gpl3+)))
-- 
2.6.4

Re: [PATCH 0/1] Move cursynth to music.scm

[Eric Bavier]

On Mon, 28 Dec 2015 18:09:09 -0500
Leo Famulari <leo@famulari.name> wrote:

> I think it would be better for this software synthesizer to be in
> music.scm.
> 
> Thoughts?

IIRC, the original thought was that many GNU packages have their own
modules, so this was done for cursynth as well.

> Leo Famulari (1):
>   gnu: Move cursynth to (gnu packages music).
> 
>  gnu-system.am             |  1 -
>  gnu/packages/cursynth.scm | 53 -----------------------------------------------
>  gnu/packages/music.scm    | 27 ++++++++++++++++++++++++
>  3 files changed, 27 insertions(+), 54 deletions(-)
>  delete mode 100644 gnu/packages/cursynth.scm
> 

Re: [PATCH 0/1] Move cursynth to music.scm

[Leo Famulari]

On Mon, Dec 28, 2015 at 05:17:15PM -0600, Eric Bavier wrote:
> On Mon, 28 Dec 2015 18:09:09 -0500
> Leo Famulari <leo@famulari.name> wrote:
> 
> > I think it would be better for this software synthesizer to be in
> > music.scm.
> > 
> > Thoughts?
> 
> IIRC, the original thought was that many GNU packages have their own
> modules, so this was done for cursynth as well.

Okay, sure.

To be honest, I don't understand the reasoning behind grouping packages
into modules. Is it just for humans or is there some technical reason
for it?

> 
> > Leo Famulari (1):
> >   gnu: Move cursynth to (gnu packages music).
> > 
> >  gnu-system.am             |  1 -
> >  gnu/packages/cursynth.scm | 53 -----------------------------------------------
> >  gnu/packages/music.scm    | 27 ++++++++++++++++++++++++
> >  3 files changed, 27 insertions(+), 54 deletions(-)
> >  delete mode 100644 gnu/packages/cursynth.scm
> > 
> 

Re: [PATCH 0/1] Move cursynth to music.scm

[Ricardo Wurmus]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Dec 28, 2015 at 05:17:15PM -0600, Eric Bavier wrote:
>> On Mon, 28 Dec 2015 18:09:09 -0500
>> Leo Famulari <leo@famulari.name> wrote:
>> 
>> > I think it would be better for this software synthesizer to be in
>> > music.scm.
>> > 
>> > Thoughts?
>> 
>> IIRC, the original thought was that many GNU packages have their own
>> modules, so this was done for cursynth as well.
>
> Okay, sure.

I think it would be nice to have cursynth in “music.scm”.  I wasn’t
fully aware of its existence, and I’m at home in “audio.scm” and
“music.scm” :)

> To be honest, I don't understand the reasoning behind grouping packages
> into modules. Is it just for humans or is there some technical reason
> for it?

It’s mostly for humans AFAIU.  Personally, I prefer try to avoid a
proliferation of one-off modules; maybe because I don’t like the
boilerplate (license header, module definition with imports, adding the
module to “gnu-system.am”).

Grouping packages in modules also allows user interfaces like guix-web
to narrow results to just a single module.  For example, searching for
“bioinfo” in guix-web shows me everything from the “bioinformatics.scm”
module, even though not all packages there contain the string “bioinfo”
in their synopsis/description.

~~ Ricardo

Re: [PATCH 0/1] Move cursynth to music.scm

[Alex Kost]

Ricardo Wurmus (2015-12-29 10:08 +0300) wrote:

> Grouping packages in modules also allows user interfaces like guix-web
> to narrow results to just a single module.  For example, searching for
> “bioinfo” in guix-web shows me everything from the “bioinformatics.scm”
> module, even though not all packages there contain the string “bioinfo”
> in their synopsis/description.

Wow, cool, I assume it is done by searching in "location" package field
(I don't see how it can be implemented otherwise).  In emacs interafce
there is 'guix-search-params' variable for this purpose.  So after:

  (setq guix-search-params '(name synopsis description location))

"M-x guix-search-by-regexp bioinfo" should also display all packages
from "bioinformatics.scm".


P.S.  I forgot to mention in a message I've just sent that this variable
is renamed to 'guix-package-search-params' in wip-refactor-emacs-ui
branch.

-- 
Alex

Re: [PATCH 0/1] Move cursynth to music.scm

[Leo Famulari]

On Tue, Dec 29, 2015 at 08:08:49AM +0100, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Mon, Dec 28, 2015 at 05:17:15PM -0600, Eric Bavier wrote:
> >> On Mon, 28 Dec 2015 18:09:09 -0500
> >> Leo Famulari <leo@famulari.name> wrote:
> >> 
> >> > I think it would be better for this software synthesizer to be in
> >> > music.scm.
> >> > 
> >> > Thoughts?
> >> 
> >> IIRC, the original thought was that many GNU packages have their own
> >> modules, so this was done for cursynth as well.
> >
> > Okay, sure.
> 
> I think it would be nice to have cursynth in “music.scm”.  I wasn’t
> fully aware of its existence, and I’m at home in “audio.scm” and
> “music.scm” :)
> 
> > To be honest, I don't understand the reasoning behind grouping packages
> > into modules. Is it just for humans or is there some technical reason
> > for it?
> 
> It’s mostly for humans AFAIU.  Personally, I prefer try to avoid a
> proliferation of one-off modules; maybe because I don’t like the
> boilerplate (license header, module definition with imports, adding the
> module to “gnu-system.am”).

I agree about the boilerplate but I am wondering, is there a tool to get
the list of modules imported for a particular package?

> 
> Grouping packages in modules also allows user interfaces like guix-web
> to narrow results to just a single module.  For example, searching for
> “bioinfo” in guix-web shows me everything from the “bioinformatics.scm”
> module, even though not all packages there contain the string “bioinfo”
> in their synopsis/description.
> 
> ~~ Ricardo
> 

Re: [PATCH 0/1] Move cursynth to music.scm

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Mon, Dec 28, 2015 at 05:17:15PM -0600, Eric Bavier wrote:
>>> On Mon, 28 Dec 2015 18:09:09 -0500
>>> Leo Famulari <leo@famulari.name> wrote:
>>> 
>>> > I think it would be better for this software synthesizer to be in
>>> > music.scm.
>>> > 
>>> > Thoughts?
>>> 
>>> IIRC, the original thought was that many GNU packages have their own
>>> modules, so this was done for cursynth as well.
>>
>> Okay, sure.
>
> I think it would be nice to have cursynth in “music.scm”.

+1

>> To be honest, I don't understand the reasoning behind grouping packages
>> into modules. Is it just for humans or is there some technical reason
>> for it?
>
> It’s mostly for humans AFAIU.  Personally, I prefer try to avoid a
> proliferation of one-off modules; maybe because I don’t like the
> boilerplate (license header, module definition with imports, adding the
> module to “gnu-system.am”).

Same here.

More modules also lead to more I/O for the various commands.

Ludo’.

Re: [PATCH 0/1] Move cursynth to music.scm

[Leo Famulari]

On Wed, Dec 30, 2015 at 12:33:25AM +0100, Ludovic Courtès wrote:
> Ricardo Wurmus <rekado@elephly.net> skribis:
> 
> > Leo Famulari <leo@famulari.name> writes:
> >
> >> On Mon, Dec 28, 2015 at 05:17:15PM -0600, Eric Bavier wrote:
> >>> On Mon, 28 Dec 2015 18:09:09 -0500
> >>> Leo Famulari <leo@famulari.name> wrote:
> >>> 
> >>> > I think it would be better for this software synthesizer to be in
> >>> > music.scm.
> >>> > 
> >>> > Thoughts?
> >>> 
> >>> IIRC, the original thought was that many GNU packages have their own
> >>> modules, so this was done for cursynth as well.
> >>
> >> Okay, sure.
> >
> > I think it would be nice to have cursynth in “music.scm”.
> 
> +1
> 
> >> To be honest, I don't understand the reasoning behind grouping packages
> >> into modules. Is it just for humans or is there some technical reason
> >> for it?
> >
> > It’s mostly for humans AFAIU.  Personally, I prefer try to avoid a
> > proliferation of one-off modules; maybe because I don’t like the
> > boilerplate (license header, module definition with imports, adding the
> > module to “gnu-system.am”).
> 
> Same here.
> 
> More modules also lead to more I/O for the various commands.

That's a good reason.

I'll apply the patch if there are no objections.

> 
> Ludo’.

Re: [PATCH 0/1] Move cursynth to music.scm

[Leo Famulari]

On Tue, Dec 29, 2015 at 08:10:02PM -0500, Leo Famulari wrote:
> On Wed, Dec 30, 2015 at 12:33:25AM +0100, Ludovic Courtès wrote:
> > Ricardo Wurmus <rekado@elephly.net> skribis:
> > 
> > > Leo Famulari <leo@famulari.name> writes:
> > >
> > >> On Mon, Dec 28, 2015 at 05:17:15PM -0600, Eric Bavier wrote:
> > >>> On Mon, 28 Dec 2015 18:09:09 -0500
> > >>> Leo Famulari <leo@famulari.name> wrote:
> > >>> 
> > >>> > I think it would be better for this software synthesizer to be in
> > >>> > music.scm.
> > >>> > 
> > >>> > Thoughts?
> > >>> 
> > >>> IIRC, the original thought was that many GNU packages have their own
> > >>> modules, so this was done for cursynth as well.
> > >>
> > >> Okay, sure.
> > >
> > > I think it would be nice to have cursynth in “music.scm”.
> > 
> > +1
> > 
> > >> To be honest, I don't understand the reasoning behind grouping packages
> > >> into modules. Is it just for humans or is there some technical reason
> > >> for it?
> > >
> > > It’s mostly for humans AFAIU.  Personally, I prefer try to avoid a
> > > proliferation of one-off modules; maybe because I don’t like the
> > > boilerplate (license header, module definition with imports, adding the
> > > module to “gnu-system.am”).
> > 
> > Same here.
> > 
> > More modules also lead to more I/O for the various commands.
> 
> That's a good reason.
> 
> I'll apply the patch if there are no objections.

Pushed as 658212ebf7.

> 
> > 
> > Ludo’.
>