From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/3] support: Rename user-dmddir to %user-shepherd-dir.
Date: Sun, 17 Jan 2016 15:19:11 +0100
Message-ID: <87wpr870gw.fsf@gnu.org>
References: <1452982661-17268-1-git-send-email-mthl@gnu.org>
	<1452982661-17268-4-git-send-email-mthl@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aKoAq-00048T-3p
	for guix-devel@gnu.org; Sun, 17 Jan 2016 09:19:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aKoAl-0006i2-5F
	for guix-devel@gnu.org; Sun, 17 Jan 2016 09:19:20 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57771)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1aKoAl-0006hx-2S
	for guix-devel@gnu.org; Sun, 17 Jan 2016 09:19:15 -0500
In-Reply-To: <1452982661-17268-4-git-send-email-mthl@gnu.org> (Mathieu
	Lirzin's message of "Sat, 16 Jan 2016 23:17:41 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org

Mathieu Lirzin <mthl@gnu.org> skribis:

> * modules/shepherd/support.scm (user-dmddir): Rename to ...
> (%user-shepherd-dir): ... this.  Honor XDG variables and use
> '~/.config/shepherd' as default value.  All consumers changed.
> (mkdir-p): New procedure.  Export it.
> (default-config-file): Use it.
> (verify-dir): Likewise.

Cool!

> +(define %user-shepherd-dir
> +  ;; sheperd default directory if shepherd is run as a normal user.
         ^^^
Typo.  :-)

I would rename the variable to =E2=80=98%user-config-dir=E2=80=99 or simila=
r; I think
it=E2=80=99s putting the package name everywhere just makes it more difficu=
lt to
rename it.  :-)

> +  (string-append (or (getenv "XDG_CONFIG_HOME")
> +		     (string-append user-homedir "/.config"))
   ^^^
No tabs please!

Could you update shepherd.texi to so that it mentions the right
location, make sure XDG_CACHE_HOME is unset in AM_TESTS_ENVIRONMENT (or
similar), also add a test in basic.sh?

The test would essentially be done at the end of basic.sh, setting
XDG_CACHE_HOME to some temporary place and making sure that =E2=80=98shephe=
rd=E2=80=99
loads the file.

Thank you!  It=E2=80=99s great to see people have worked on to-do items whi=
le I
was away from keyboard!  :-)

Ludo=E2=80=99.