unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Allan Webber <cwebber@dustycloud.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: gnu: Add python-wtforms.
Date: Sat, 13 Feb 2016 14:57:29 -0800	[thread overview]
Message-ID: <87wpq8te06.fsf@dustycloud.org> (raw)
In-Reply-To: <20160213222307.GA1127@jasmine>

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Leo Famulari writes:

> On Sat, Feb 13, 2016 at 01:55:01PM -0800, Christopher Allan Webber wrote:
>> Christopher Allan Webber writes:
>
> [...]
>
>> >>> * gnu/packages/python.scm (python-wtforms, python2-wtforms): New variables.
>> >>
>> >> It looks good to me, but I wonder if the python-3 variant really needs
>> >> setuptools? If so, okay. If not, can you use the new python2-variant
>> >> system [0] to provide setuptools for python2-wtforms?
>> >>
>> >> [0] Introduced in 48b311b1b3ba
>> >
>> > Okay, I'll give that a try, and will make an adjustment if appropriate,
>> > and regardless, push after figuring that out.
>> >
>> > Thanks to both of you!
>> 
>> Well, I think it's significant enough of a change where I should get
>> some validation that everything looks right before I push.  New version,
>> ahoy!  Is it ok?
>
> I believe that you still must call 'package-with-python2' in the
> python-2 variant, and the argument to that should be
> (strip-python2-variant python-foo).
>
> I've attached an example commit that seems to work, from one of my WIP
> branches.

Ah, you're right!  New patch!

 - Chris


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-wtforms.patch --]
[-- Type: text/x-patch, Size: 1759 bytes --]

From 6d3d18425409a738b6e341d9f1640f048a12300a Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Sat, 13 Feb 2016 13:42:51 -0800
Subject: [PATCH] gnu: Add python-wtforms

* gnu/packages/python.scm (python-wtforms, python2-wtforms): New variables.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 3758eed..c9aabc8 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -7509,3 +7509,33 @@ input.  (Note that this is mostly a legacy library; you may wish to look at
 python-xdo for newer bindings.)")
     (license bsd-3)))
 
+(define-public python-wtforms
+  (package
+    (name "python-wtforms")
+    (version "2.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "WTForms" version ".zip"))
+       (sha256
+        (base32
+         "0vyl26y9cg409cfyj8rhqxazsdnd0jipgjw06civhrd53yyi1pzz"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("unzip" ,unzip)))
+    (home-page "http://wtforms.simplecodes.com/")
+    (synopsis
+     "Form validation and rendering library for Python web development")
+    (description
+     "WTForms is a flexible forms validation and rendering library
+for Python web development.  It is very similar to the web form API
+available in Django, but is a standalone package.")
+    (license bsd-3)
+    (properties `((python2-variant . ,(delay python2-wtforms))))))
+
+(define-public python2-wtforms
+  (package
+    (inherit (package-with-python2
+              (strip-python2-variant python-wtforms)))
+    (name "python2-wtforms")
+    (inputs `(("python2-setuptools" ,python2-setuptools)))))
-- 
2.6.3


  reply	other threads:[~2016-02-13 22:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 19:43 gnu: Add python-wtforms Christopher Allan Webber
2016-02-12 21:52 ` Thompson, David
2016-02-12 23:42   ` Christopher Allan Webber
2016-02-12 23:57     ` Leo Famulari
2016-02-13 21:55     ` Christopher Allan Webber
2016-02-13 22:23       ` Leo Famulari
2016-02-13 22:57         ` Christopher Allan Webber [this message]
2016-02-13 23:07           ` Christopher Allan Webber
2016-02-12 22:02 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpq8te06.fsf@dustycloud.org \
    --to=cwebber@dustycloud.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).