From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: Gnome-updates Date: Mon, 02 May 2016 22:47:16 +0800 Message-ID: <87wpncldor.fsf@member.fsf.org> References: <20160426173717.GA4754@solar> <87potb19ih.fsf@gnu.org> <87r3dr3yyc.fsf@member.fsf.org> <87y47yyhh3.fsf@gnu.org> <87pot73390.fsf@member.fsf.org> <878tzseuwl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axF8g-0005Iy-I3 for guix-devel@gnu.org; Mon, 02 May 2016 10:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axF8U-0005q0-DG for guix-devel@gnu.org; Mon, 02 May 2016 10:47:53 -0400 In-Reply-To: <878tzseuwl.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 02 May 2016 10:17:14 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello! > > iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis: > >> - Disable a failing rtprtx test of gst-plugins-good. >> I can pass it using `guix environment', but fail with `guix build'. > > The log for this commit contains a typo: it doesn=E2=80=99t mention the v= ariable > name, only the =E2=80=98arguments=E2=80=99 field. Also, could you add a = comment that > says why we disable this test? > > With this comment, I think it=E2=80=99s OK. Oh, thanks! > >> - Add xdg-desktop-database and xdg-mime-database hooks. >> I pick it from my old branch, and notice that my old code really >> requires shared-mime-info and desktop-file-utils to be installed >> explicitly.. So I factor out the 'manifest-lookup-package' proceduce >> used by gtk-icon-themes to allow find them in the propagated-inputs >> in manifest. (or maybe I should lookup for glib? but I think it's >> ok now since I add them to the gnome meta package) > > Sounds good, but it=E2=80=99s not directly related to this branch, is it?= Would > have been best to submit for inclusion in =E2=80=98master=E2=80=99, if po= ssible. Yes.. > > At first sight these 3 patches look good. > >> - Drop the 'loaders.cache' file from librsvg. >> Since we have use gdk-pixbuf+svg for gtk+, gtk+ applications can use >> SVG without wrap with it. I have tested key-mon (works), but not >> solfege (too slow to download texlive..). > > OK. > >> - Disable the Spell plugin of gedit. >> It now needs gspell, which doesn't work due to enchant can't list >> dicts of aspell. Report it as: >> >> (Does it works before?) > > No idea, but OK. (Thanks for emailing the Aspell folks!) > >> - Skip 'test_utf8_inout' of gjs. >> it fails with gobject-introspection-1.48.0, but use python3 to >> call the test in Regress.typelib will pass. Report as: >> >> (No one notice yet.) > > I would prefer this one to be fixed, because it=E2=80=99s worrisome that = such a > basic feature is broken. Agree, but the only user of gjs is gnome-shell, and it seems works, so I guess we could leave it for later? > > The bug report above mentions a dangling pointer. Do you have a > backtrace or something to illustrate that? Did you set a breakpoint on > =E2=80=98regress_test_utf8_inout=E2=80=99 or something? No, I find it with some print functions.. > >> Also, 1 test of libsoup on x86_64 fails (other systems fine): >> . >> Should we skip it, or retry the build on hydra? > > The failing test is: > > ERROR: multipart-test - exited with status 139 (terminated by signal 11?) > > Signal 11 doesn=E2=80=99t sound good. :-) > > However, I can=E2=80=99t reproduce it on my machine: > > $ ./pre-inst-env guix build libsoup --check --no-grafts -q > /gnu/store/km0g7xmsngs1yd8ix08pkifk152qifss-libsoup-2.54.1 > /gnu/store/fbq6hal96vfy556sybzwhyj879w8pgr5-libsoup-2.54.1-doc > $ git describe > v0.10.0-612-g0a24549 > > So unless someone can reproduce it and get more info, I=E2=80=99d be in f= avor of > retrying. OK. Thanks for the review. I have rebase it upon master again with the one log change but leave out the poppler CVE-2015-8868 fix (it's in 0.42.0) in master. (I can't use force push so I delete and push it again..)