unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] Add more symlinks to python-wrapper
@ 2016-04-21 20:23 Hartmut Goebel
  2016-04-21 20:23 ` [PATCH] gnu: wrap-python3: create more symlinks Hartmut Goebel
  0 siblings, 1 reply; 12+ messages in thread
From: Hartmut Goebel @ 2016-04-21 20:23 UTC (permalink / raw)
  To: guix-devel

Enclosed patch adds missing sysmlinks "python-config" and "pip" to
python-wrapper.

I did not add a symlink for easy_install, this this is obsoleted by pip.

Hartmut Goebel (1):
  gnu: wrap-python3: create more symlinks.

 gnu/packages/python.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH] gnu: wrap-python3: create more symlinks.
  2016-04-21 20:23 [PATCH] Add more symlinks to python-wrapper Hartmut Goebel
@ 2016-04-21 20:23 ` Hartmut Goebel
  2016-04-30  2:05   ` Leo Famulari
  0 siblings, 1 reply; 12+ messages in thread
From: Hartmut Goebel @ 2016-04-21 20:23 UTC (permalink / raw)
  To: guix-devel

* gnu/pyckages/python.csm (wrap-python3): Create symlinks for
  pip and python-config, too.
---
 gnu/packages/python.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 65210e0..5c4bf3b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
 ;;; Copyright © 2015, 2016 Chris Marusich <cmmarusich@gmail.com>
 ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -334,8 +335,8 @@ data types.")
                   (lambda (old new)
                     (symlink (string-append python old)
                              (string-append bin "/" new)))
-                  `("python3" ,"pydoc3" ,"idle3")
-                  `("python"  ,"pydoc"  ,"idle"))))))
+                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
+                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
     (synopsis "Wrapper for the Python 3 commands")
     (description
      "This package provides wrappers for the commands of Python@tie{}3.x such
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-04-21 20:23 ` [PATCH] gnu: wrap-python3: create more symlinks Hartmut Goebel
@ 2016-04-30  2:05   ` Leo Famulari
  2016-05-05 14:58     ` Ludovic Courtès
  0 siblings, 1 reply; 12+ messages in thread
From: Leo Famulari @ 2016-04-30  2:05 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

On Thu, Apr 21, 2016 at 10:23:19PM +0200, Hartmut Goebel wrote:
> * gnu/pyckages/python.csm (wrap-python3): Create symlinks for
>   pip and python-config, too.

[...]

> +++ b/gnu/packages/python.scm
> -                  `("python3" ,"pydoc3" ,"idle3")
> -                  `("python"  ,"pydoc"  ,"idle"))))))
> +                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
> +                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))

Do any Pythonista's have any comments on this proposal?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-04-30  2:05   ` Leo Famulari
@ 2016-05-05 14:58     ` Ludovic Courtès
  2016-05-05 16:41       ` Alex Kost
  0 siblings, 1 reply; 12+ messages in thread
From: Ludovic Courtès @ 2016-05-05 14:58 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

Leo Famulari <leo@famulari.name> skribis:

> On Thu, Apr 21, 2016 at 10:23:19PM +0200, Hartmut Goebel wrote:
>> * gnu/pyckages/python.csm (wrap-python3): Create symlinks for
>>   pip and python-config, too.
>
> [...]
>
>> +++ b/gnu/packages/python.scm
>> -                  `("python3" ,"pydoc3" ,"idle3")
>> -                  `("python"  ,"pydoc"  ,"idle"))))))
>> +                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
>> +                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
>
> Do any Pythonista's have any comments on this proposal?

I’m not much of a Pythonista, but this look good to me.
Could you push to core-updates?

Thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-05-05 14:58     ` Ludovic Courtès
@ 2016-05-05 16:41       ` Alex Kost
  2016-05-06 18:15         ` Leo Famulari
  0 siblings, 1 reply; 12+ messages in thread
From: Alex Kost @ 2016-05-05 16:41 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Ludovic Courtès (2016-05-05 17:58 +0300) wrote:

> Leo Famulari <leo@famulari.name> skribis:
>
>> On Thu, Apr 21, 2016 at 10:23:19PM +0200, Hartmut Goebel wrote:
>>> * gnu/pyckages/python.csm (wrap-python3): Create symlinks for
>>>   pip and python-config, too.
>>
>> [...]
>>
>>> +++ b/gnu/packages/python.scm
>>> -                  `("python3" ,"pydoc3" ,"idle3")
>>> -                  `("python"  ,"pydoc"  ,"idle"))))))
>>> +                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
>>> +                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
>>
>> Do any Pythonista's have any comments on this proposal?
>
> I’m not much of a Pythonista, but this look good to me.
> Could you push to core-updates?

I was going to say that these lists of strings are strangely quoted, but
then I saw that Mark fixed it in the core-updates¹, so this patch should
be adjusted accordingly.

¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=5c19dab94591db68c5361bc2521321fc587dc704

-- 
Alex

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-05-05 16:41       ` Alex Kost
@ 2016-05-06 18:15         ` Leo Famulari
  0 siblings, 0 replies; 12+ messages in thread
From: Leo Famulari @ 2016-05-06 18:15 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel

On Thu, May 05, 2016 at 07:41:02PM +0300, Alex Kost wrote:
> Ludovic Courtès (2016-05-05 17:58 +0300) wrote:
> 
> > Leo Famulari <leo@famulari.name> skribis:
> >
> >> On Thu, Apr 21, 2016 at 10:23:19PM +0200, Hartmut Goebel wrote:
> >>> * gnu/pyckages/python.csm (wrap-python3): Create symlinks for
> >>>   pip and python-config, too.
> >>
> >> [...]
> >>
> >>> +++ b/gnu/packages/python.scm
> >>> -                  `("python3" ,"pydoc3" ,"idle3")
> >>> -                  `("python"  ,"pydoc"  ,"idle"))))))
> >>> +                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
> >>> +                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
> >>
> >> Do any Pythonista's have any comments on this proposal?
> >
> > I’m not much of a Pythonista, but this look good to me.
> > Could you push to core-updates?
> 
> I was going to say that these lists of strings are strangely quoted, but
> then I saw that Mark fixed it in the core-updates¹, so this patch should
> be adjusted accordingly.

Committed to core-updates with the requested changes as 478e75b53b.

> 
> ¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=5c19dab94591db68c5361bc2521321fc587dc704
> 
> -- 
> Alex

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH] gnu: wrap-python3: create more symlinks.
  2016-06-14 21:14 [PATCH] Add more symlinks to python-wrapper Hartmut Goebel
@ 2016-06-14 21:14 ` Hartmut Goebel
  2016-06-14 21:17   ` Hartmut Goebel
  2016-06-15 14:27   ` Andreas Enge
  0 siblings, 2 replies; 12+ messages in thread
From: Hartmut Goebel @ 2016-06-14 21:14 UTC (permalink / raw)
  To: guix-devel

* gnu/pyckages/python.csm (wrap-python3): Create symlinks for
  pip and python-config, too.
---
 gnu/packages/python.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 65210e0..5c4bf3b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
 ;;; Copyright © 2015, 2016 Chris Marusich <cmmarusich@gmail.com>
 ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
+;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -334,8 +335,8 @@ data types.")
                   (lambda (old new)
                     (symlink (string-append python old)
                              (string-append bin "/" new)))
-                  `("python3" ,"pydoc3" ,"idle3")
-                  `("python"  ,"pydoc"  ,"idle"))))))
+                  `("python3" ,"pydoc3" ,"idle3" ,"pip3" ,"python3-config")
+                  `("python"  ,"pydoc"  ,"idle"  ,"pip"  ,"python-config"))))))
     (synopsis "Wrapper for the Python 3 commands")
     (description
      "This package provides wrappers for the commands of Python@tie{}3.x such
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-06-14 21:14 ` [PATCH] gnu: wrap-python3: create more symlinks Hartmut Goebel
@ 2016-06-14 21:17   ` Hartmut Goebel
  2016-06-15 14:27   ` Andreas Enge
  1 sibling, 0 replies; 12+ messages in thread
From: Hartmut Goebel @ 2016-06-14 21:17 UTC (permalink / raw)
  To: guix-devel


[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]

Sorry, this patch was accidentaly resend.

-- 
Schönen Gruß
Hartmut Goebel
Dipl.-Informatiker (univ), CISSP, CSSLP, ISO 27001 Lead Implementer
Information Security Management, Security Governance, Secure Software
Development

Goebel Consult, Landshut
http://www.goebel-consult.de

Blog:
http://www.goebel-consult.de/blog/liberario-als-alternative-zum-db-navigator-und-zu-offi

Kolumne: http://www.cissp-gefluester.de/2010-01-hinterturen-allen-ortes


[-- Attachment #1.2: Type: text/html, Size: 1425 bytes --]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2430 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-06-14 21:14 ` [PATCH] gnu: wrap-python3: create more symlinks Hartmut Goebel
  2016-06-14 21:17   ` Hartmut Goebel
@ 2016-06-15 14:27   ` Andreas Enge
  2016-06-17 19:45     ` Hartmut Goebel
  1 sibling, 1 reply; 12+ messages in thread
From: Andreas Enge @ 2016-06-15 14:27 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hi Hartmut,

the content of the patch looks good, but I cannot apply it with "git am";
is it relative to an older git commit? I could correct it myself, but
then you would disappear as an author.

Andreas

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-06-15 14:27   ` Andreas Enge
@ 2016-06-17 19:45     ` Hartmut Goebel
  2016-06-20  9:10       ` Andreas Enge
  0 siblings, 1 reply; 12+ messages in thread
From: Hartmut Goebel @ 2016-06-17 19:45 UTC (permalink / raw)
  To: Andreas Enge; +Cc: guix-devel

Hello Andreas,

Am 15.06.2016 um 16:27 schrieb Andreas Enge:
> the content of the patch looks good, but I cannot apply it with "git am";
> is it relative to an older git commit? I could correct it myself, but
> then you would disappear as an author.

I've jsut send an updated version of the patch. I'd appreciate if you
could take care of it.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-06-17 19:45     ` Hartmut Goebel
@ 2016-06-20  9:10       ` Andreas Enge
  2016-06-23 19:57         ` Andreas Enge
  0 siblings, 1 reply; 12+ messages in thread
From: Andreas Enge @ 2016-06-20  9:10 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hello Hartmut,

On Fri, Jun 17, 2016 at 09:45:22PM +0200, Hartmut Goebel wrote:
> I've jsut send an updated version of the patch. I'd appreciate if you
> could take care of it.

thanks a lot! I applied it locally and was about to push it to master,
when I started to wonder:
$ ./pre-inst-env guix refresh -l python-wrapper
Building the following 558 packages would ensure 1569 dependent packages are rebuilt

This is maybe too much right now; question to those who suffer the most from
core-updates: Should I push it to core-updates-next? This patch is nice to
have, but probably not very urgent.

Andreas

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] gnu: wrap-python3: create more symlinks.
  2016-06-20  9:10       ` Andreas Enge
@ 2016-06-23 19:57         ` Andreas Enge
  0 siblings, 0 replies; 12+ messages in thread
From: Andreas Enge @ 2016-06-23 19:57 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

On Mon, Jun 20, 2016 at 11:10:20AM +0200, Andreas Enge wrote:
> This is maybe too much right now; question to those who suffer the most from
> core-updates: Should I push it to core-updates-next? This patch is nice to
> have, but probably not very urgent.

I just pushed to core-updates-next.

Andreas

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-06-23 19:57 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-21 20:23 [PATCH] Add more symlinks to python-wrapper Hartmut Goebel
2016-04-21 20:23 ` [PATCH] gnu: wrap-python3: create more symlinks Hartmut Goebel
2016-04-30  2:05   ` Leo Famulari
2016-05-05 14:58     ` Ludovic Courtès
2016-05-05 16:41       ` Alex Kost
2016-05-06 18:15         ` Leo Famulari
  -- strict thread matches above, loose matches on Subject: below --
2016-06-14 21:14 [PATCH] Add more symlinks to python-wrapper Hartmut Goebel
2016-06-14 21:14 ` [PATCH] gnu: wrap-python3: create more symlinks Hartmut Goebel
2016-06-14 21:17   ` Hartmut Goebel
2016-06-15 14:27   ` Andreas Enge
2016-06-17 19:45     ` Hartmut Goebel
2016-06-20  9:10       ` Andreas Enge
2016-06-23 19:57         ` Andreas Enge

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).