From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add Elixir Date: Tue, 2 Aug 2016 23:25:30 +0200 Message-ID: <87wpjyualx.fsf@mdc-berlin.de> References: <579027b7.VHXjhpPxQC3AAmeY%pjotr.public12@email> <87mvl66ya6.fsf@elephly.net> <20160725063140.GA25432@thebird.nl> <87wpjz4l2c.fsf@elephly.net> <87vazj84ln.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUhC2-0007ci-UN for guix-devel@gnu.org; Tue, 02 Aug 2016 17:25:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUhBy-0000Cj-HE for guix-devel@gnu.org; Tue, 02 Aug 2016 17:25:41 -0400 In-Reply-To: <87vazj84ln.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s writes: > Hello! > > Ricardo Wurmus skribis: > >> I documented the most common test errors, but there don=E2=80=99t seem= to be any >> quick fixes. Attached is a new patch based on yours. If this looks >> good to you I=E2=80=99ll push it with you as the commit author and wit= h a >> =E2=80=9CCo-authored-by: Ricardo Wurmus=E2=80=9D line in the commit su= mmary. > > Woow, congratulation, and a big thanks for taking the time to > investigate the issues! > >> +++ b/gnu/packages/patches/elixir-disable-failing-tests.patch >> @@ -0,0 +1,261 @@ >> +Most of these tests fail for unknown reasons when run in the chroot >> +environment of a Guix build process. >> + >> +Common failures are: >> + >> + * Mix.Shell.cmd() fails with error 130 > > Could it be that this method relies on /bin/sh? We have > patches/substitutions for similar functions in libc, gawk, and Guile, > for instance. It uses =E2=80=9Csh -c=E2=80=9D and even after replacing =E2=80=9Csh=E2=80= =9D with the result of =E2=80=9C(which "sh")=E2=80=9D the errors remained, so I removed the change again. >> + * The git_repo fixture cannot be found >> + * Communication with spawned processes fails with EPIPE > > It might be that processes are spawned with /bin/sh too, and thus fail > instantly. I=E2=80=99m not familiar enough with Erlang/Elixir to understand exactly = what=E2=80=99s going on. As far as I could see there are no explicit references to =E2=80=9C/bin/sh=E2=80=9D in the code. I pushed the commit as 0a4ebe01481d8f899bfc8849a27c1cf33c271c24. Thanks, Pjotr, for the work! ~~ Ricardo