From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 8/9] services: Add sddm service.
Date: Sat, 03 Sep 2016 15:32:36 +0200
Message-ID: <87wpitm7m3.fsf@gnu.org>
References: <20160901155711.7388-1-david@craven.ch>
	<20160901155711.7388-8-david@craven.ch>
	<87zinqsd2a.fsf@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bgB3s-0000FD-2C
	for guix-devel@gnu.org; Sat, 03 Sep 2016 09:32:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bgB3n-0000vC-S9
	for guix-devel@gnu.org; Sat, 03 Sep 2016 09:32:43 -0400
In-Reply-To: <87zinqsd2a.fsf@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIn?=
	=?utf-8?B?cw==?= message of "Fri, 02 Sep 2016 20:26:05 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@member.fsf.org>
Cc: guix-devel@gnu.org

Hi!

iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:

> [...]
>> +
>> +(define (sddm-activation config)
>> +  "Return the activation gexp for CONFIG."
>> +  #~(begin
>> +      (symlink #$(sddm-configuration-file config) "/etc/sddm.conf")))
>
> I don't know the behavior of activation when reconfigure services,

=E2=80=98guix system reconfigure=E2=80=99 runs the new system=E2=80=99s act=
ivation script.

> but this `symlink' call will fail when the file already exists.

Indeed.

> And to put files to /etc, it's better to extend the `etc-service-type'.

Agreed.

However, it=E2=80=99s even better to avoid populating /etc altogether; idea=
lly
/etc should contain only global configuration files, such as
nsswitch.conf.

Could you instead pass the configuration file via a command-line option
or environment variable?

> Oh, finally we get a modern display manager, thanks!

Seconded.  Thank you!

Ludo=E2=80=99.