Re: [PATCH 3/3] gnu: Add CUPS service.

[Ricardo Wurmus <rekado@elephly.net>]

Andy Wingo <wingo@igalia.com> writes:

> * gnu/services/cups.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add gnu/services/cups.scm.
> * doc/guix.texi (Printing Services): New section.

[…]

> +The CUPS configuration controls the basic things about your CUPS
> +installation: what interfaces it listens on, what to do if a print job
> +fails, how much logging to do, and so on.  To actually add a printer,
> +you have to visit the @url{http://localhost:631} URL, or use a tool such
> +as GNOME's printer configuration services.  By default, configuring a
> +CUPS service will generate a self-signed certificate if needed, for
> +secure connections to the print server.
> +
> +One way you might want to customize CUPS is to enable or disable the web interface.  You can do that directly, like this:

This line is a little long.

> +Available @code{cups-configuration} fields are:
> +
> +@deftypevr {@code{cups-configuration} parameter} package cups
> +The CUPS package.
> +@end deftypevr
> +
> +@deftypevr {@code{cups-configuration} parameter} package-list extensions
> +Drivers and other extensions to the CUPS package.
> +@end deftypevr
> +
> +@deftypevr {@code{cups-configuration} parameter} files-configuration files-configuration
> +Configuration of where to write logs, what directories to use for print
> +spools, and related privileged configuration parameters.
> +
> +Available @code{files-configuration} fields are:
> +
> +@deftypevr {@code{files-configuration} parameter} log-location access-log
> +Defines the access log filename. Specifying a blank filename disables
> +access log generation. The value @code{stderr} causes log entries to be sent
> +to the standard error file when the scheduler is running in the foreground, or
> +to the system log daemon when run in the background. The value @code{syslog}
> +causes log entries to be sent to the system log daemon. The server name may be
> +included in filenames using the string @code{%s}, as in

Please use double-spacing between sentences.  (Also in paragraphs below
this one.)  Since this is generated documentation this should be fixed
in (gnu services cups).

> +@deftypevr {@code{cups-configuration} parameter} string default-paper-size
> +Specifies the default paper size for new print queues. "Auto" uses a
> +locale-specific default, while "None" specifies there is no default paper
> +size.  Specific size names are typically "Letter" or "A4".
> +Defaults to @samp{"Auto"}.
> +@end deftypevr

Should the possible values (“Auto”, “None”, “Letter”, “A4”) be wrapped
in @code or @samp?

At this point I have to take a break from looking at the documentation.
I had only a cursory look at gnu/services/cups.scm.

Wow.

~~ Ricardo