unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add coda.
Date: Tue, 25 Oct 2016 14:58:08 +0200	[thread overview]
Message-ID: <87wpgw60wv.fsf@gnu.org> (raw)
In-Reply-To: <20161025.111526.2061537021575714460.post@thomasdanckaert.be> (Thomas Danckaert's message of "Tue, 25 Oct 2016 11:15:26 +0200 (CEST)")

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> From 56ba046e6c176e8f1109bb28ab75a586daa287db Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Tue, 25 Oct 2016 10:56:46 +0200
> Subject: [PATCH] gnu: coda: Remove bundled libraries.
>
> * gnu/packages/maths.scm (coda): Remove bundled libraries.
> [source]: Add patch and snippet to remove bundled zlib, pcre and expat.
> [inputs]: Add system zlib, pcre and expat.
> * gnu/packages/patches/coda-use-system-libs.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

Woow, that was fast!

> +       (snippet ;; Make sure we don't use the bundled software.
> +        '(map (lambda (d)
> +                (delete-file-recursively (string-append "libcoda/" d) ))
                                                                        ^
I changed ‘map’ to ‘for-each’, to make it clear that this expression is
used for effects, and removed the extra space above.

Pushed, thanks!

Ludo’.

      reply	other threads:[~2016-10-25 12:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19  9:59 [PATCH] gnu: Add coda Thomas Danckaert
2016-10-19 20:13 ` Ludovic Courtès
2016-10-21  7:26   ` Thomas Danckaert
2016-10-24 21:24     ` Ludovic Courtès
2016-10-25  9:15       ` Thomas Danckaert
2016-10-25 12:58         ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpgw60wv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=post@thomasdanckaert.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).