From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH 1/2] gnu: Add drumkv1.
Date: Sat, 19 Nov 2016 20:04:32 +0800
Message-ID: <87wpfzbrqn.fsf@member.fsf.org>
References: <20161119102704.3706-1-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43014)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1c84Od-0001GP-QU
	for guix-devel@gnu.org; Sat, 19 Nov 2016 07:05:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1c84OZ-0001LJ-29
	for guix-devel@gnu.org; Sat, 19 Nov 2016 07:05:27 -0500
Received: from smtp26.openmailbox.org ([62.4.1.60]:47668
	helo=smtp11.openmailbox.org)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <iyzsong@openmailbox.org>)
	id 1c84OY-0001L9-SH
	for guix-devel@gnu.org; Sat, 19 Nov 2016 07:05:22 -0500
In-Reply-To: <20161119102704.3706-1-rekado@elephly.net> (Ricardo Wurmus's
	message of "Sat, 19 Nov 2016 11:27:03 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> writes:

> * gnu/packages/music.scm (drumkv1): New variable.
> ---
>  gnu/packages/music.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 12233bf..5e882b2 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -909,6 +909,40 @@ users to select LV2 plugins and run them with jalv.")
>  oscillators and stereo effects.")
>      (license license:gpl2+)))
>  
> +(define-public drumkv1
> +  (package
> +    (name "drumkv1")
> +    (version "0.8.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (string-append "mirror://sourceforge/drumkv1/drumkv1/" version
> +                              "/drumkv1-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1n2kd468kn71yp2asmamprvblmdlvh0zd8lsh3598dwi4b7aa3ga"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; There are no tests.
> +       #:configure-flags
> +       '("CXXFLAGS=-std=gnu++11")))
> +    (inputs
> +     `(("jack" ,jack-1)
> +       ("lv2" ,lv2)
> +       ("libsndfile" ,libsndfile)
> +       ("alsa-lib" ,alsa-lib)
> +       ("liblo" ,liblo)
> +       ("qtbase" ,qtbase)
> +       ("qttools" ,qttools)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))

Does qttools end up in the closure?  I think it's used mainly for
building locale files or documentation.  Otherwise all look good!