Re: [PATCH 1/1] gnu: tcsh: Fix out of bounds read.

[ludo@gnu.org (Ludovic Courtès)]

Leo Famulari <leo@famulari.name> skribis:

> On Wed, Dec 07, 2016 at 01:55:47PM +0100, Marius Bakke wrote:
>> Ludovic Courtès <ludo@gnu.org> writes:
>> 
>> > That could go to the next ‘staging’ branch or ‘core-updates’, which
>> > might be merged first.  (How come this many packages depend on tcsh?)
>> 
>> tcsh is used by the 'boost' and 'texlive' packages.
>
> Tcsh is a native-input of boost.
>
> I think that using a graft, as in the attached patch, should work.
>
> However, when applying this patch on top of a69bc7071ec (hydra: Fix
> wrong-num-args error when computing the cross jobs.) and building boost
> with this patch, the same derivation is built:
>
> $ ./pre-inst-env guix build boost && ./pre-inst-env guix build --no-grafts boost
> /gnu/store/nfg59rims86f87q5hasj8ngad3cd9dpa-boost-1.61.0
> /gnu/store/nfg59rims86f87q5hasj8ngad3cd9dpa-boost-1.61.0
>
> I'd expect it to change. Am I missing something?

Boost has no run-time dependency on tcsh, as shown by:

  guix size boost | grep tcsh

This is probably the reason why tcsh is in ‘native-inputs’, and also the
reason why Boost is not grafted in this case.

It’s a case where using a graft allows us to not rebuild anything when
we know it wouldn’t make any difference.

Anyway, the patch LGTM, thank you!

Ludo’.