unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Bake Timmons <65pandas@gmail.com>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add wwwoffle.
Date: Thu, 22 Dec 2016 16:58:16 +0100	[thread overview]
Message-ID: <87wpes9crr.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <1482382225.160993.3242@gnu>

[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]

Bake Timmons <65pandas@gmail.com> writes:

> * gnu/packages/web.scm (wwwoffle): New variable.
> ---
>  gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)

Thanks for this! The patch looks good, but does not build on master
because the "libgcrypt" variable cannot be found. It can be imported
from the "gnupg" module.

Some other trivial comments: Home page and source should use HTTPS when
available, and we try to add comments about why tests are disabled.
Could you also add a copyright line for yourself?

I can do these minor edits for you if you prefer, but would like to
confirm name and email for the copyright. Thanks!

>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 184869200..c4e716c2b 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -668,6 +668,34 @@ server).  It was primarily designed to be used by one person or a small group
>  of people.")
>      (license l:expat)))
>  
> +(define-public wwwoffle
> +  (package
> +    (name "wwwoffle")
> +    (version "2.9j")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.gedanken.org.uk/software/"
> +                                  "wwwoffle/download/wwwoffle-"
> +                                  version ".tgz"))
> +              (sha256
> +               (base32
> +                "1ihil1xq9dp21hf108khxbw6f3baq0w5c0j3af038y6lkmad4vdi"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags '("--with-gnutls")
> +       #:tests? #f))
> +    (native-inputs `(("flex" ,flex)))
> +    (inputs `(("gnutls" ,gnutls)
> +              ("libcrypt", libgcrypt)))
> +    (home-page "http://www.gedanken.org.uk/software/wwwoffle/")
> +    (synopsis "Caching web proxy optimized for intermittent internet links")
> +    (description "WWWOFFLE is a proxy web server that is especially good for
> +intermittent internet links.  It can cache HTTP, HTTPS, FTP, and finger
> +protocols, and supports browsing and requesting pages while offline, indexing,
> +modifying pages and incoming and outgoing headers, monitoring pages for
> +changes, and much more.")
> +    (license l:gpl2+)))
> +
>  (define-public libyaml
>    (package
>      (name "libyaml")
> -- 
> 2.11.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2016-12-22 15:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-22  4:50 [PATCH] gnu: Add wwwoffle Bake Timmons
2016-12-22 15:58 ` Marius Bakke [this message]
2016-12-23  7:19   ` Bake Timmons
2016-12-23 14:20     ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpes9crr.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
    --to=mbakke@fastmail.com \
    --cc=65pandas@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).