From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/6] gnu: Add rocksdb. Date: Wed, 18 Jan 2017 22:29:36 +0100 Message-ID: <87wpds6oqn.fsf@gnu.org> References: <20170115203338.19769-1-mbakke@fastmail.com> <20170115203338.19769-5-mbakke@fastmail.com> <87fukhb95t.fsf@gnu.org> <87a8ap9qi5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTxnc-0001bn-5I for guix-devel@gnu.org; Wed, 18 Jan 2017 16:29:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTxnX-0005Hs-Om for guix-devel@gnu.org; Wed, 18 Jan 2017 16:29:44 -0500 In-Reply-To: <87a8ap9qi5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Wed, 18 Jan 2017 01:10:58 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Marius Bakke skribis: > Ludovic Court=C3=A8s writes: > >> Marius Bakke skribis: >> >>> * gnu/packages/databases.scm (rocksdb): New variable. >> >> [...] >> >>> + (lambda* (#:key (make-flags '()) #:allow-other-keys) >>> + ;; Prevent the build from adding machine-specific optimiz= ations. >>> + ;; This does not work if passed as a make flag... >>> + (setenv "PORTABLE" "1") >>> + (and (zero? (apply system* "make" "static_lib" make-flags= )) >>> + (zero? (apply system* "make" "shared_lib" make-flags= ))))) >> >> We could avoid building the static libs if nothing requires it; no >> strong opinion though. > > I do tend to simply drop the static libs (see e.g. "dlib" or > "capnproto"), but in this case Ceph requires the static library. I will > make another attempt at making it use "-lrocksdb" instead of the ".a" > before pushing this package however, now that I know the build better. OK. > In the crypto++ case, static is the default make target, so I suspect > it's "normal" to use. But as I recently realized, grafting most likely > won't work with static libraries, so I will remove it. Being a crypto > library and all. We should discourage it indeed. Indeed. So it=E2=80=99s best to avoid static libs whenever possible. >>> + (home-page "http://rocksdb.org/") >>> + (synopsis "Persistent key-value store for fast storage") >>> + (description >>> + "RocksDB is an embeddable, persistent key-value storage library t= hat is >>> +designed for flash and RAM storage.") >> >> Could you expound a little bit? > > How about: > > (synopsis "Persistent key-value store for flash and RAM storage") > (description > "RocksDB is a library that forms the core building block for a fast > key-value server, especially suited for storing data on flash drives. > It has a Log-Structured-Merge-Database (LSM) design with flexible > tradeoffs between Write-Amplification-Factor (WAF), > Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). > It has multi-threaded compactions, making it specially suitable for > storing multiple terabytes of data in a single database. > It is based on @code{LevelDB}.") Perfect, thanks! Ludo=E2=80=99.