From: Marius Bakke <mbakke@fastmail.com>
To: Ricardo Wurmus <rekado@elephly.net>, Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org, 25177@debbugs.gnu.org
Subject: Re: bug#25177: python-tests: python-oslosphinx fixed. Please evaluate.
Date: Wed, 22 Feb 2017 13:57:16 +0100 [thread overview]
Message-ID: <87wpcifknn.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87lgsybdnq.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
Ricardo Wurmus <rekado@elephly.net> writes:
> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Tue, Feb 21, 2017 at 06:30:12PM +0100, Ricardo Wurmus wrote:
>>>> From 1ac5166df11766b47cd1ac723a464063a89afc96 Mon Sep 17 00:00:00 2001
>>>> From: Ricardo Wurmus <rekado@elephly.net>
>>>> Date: Tue, 21 Feb 2017 18:28:21 +0100
>>>> Subject: [PATCH] gnu: python-dendropy: Disable failing tests.
>>>>
>>>> * gnu/packages/bioinformatics.scm (python-dendropy): Disable two failing
>>>> tests.
>>>
>>> LGTM
>>
>> The problem was fixed in the upstream commit 93f984b in response to my
>> bug report:
>>
>> https://github.com/jeetsukumaran/DendroPy/commit/93f984bba7a6c588a28ca87f4e557ce283809453
>>
>> I believe we can just backport this fix instead of deleting the test.
>
> Here’s a patch that fixes the tests by applying the changes of the
> upstream commit. If this is fine I’ll push it to the python-tests
> branch.
LGTM, thank you!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-02-22 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 17:18 python-tests: python-oslosphinx fixed. Please evaluate Danny Milosavljevic
2017-02-19 23:00 ` Marius Bakke
2017-02-21 4:16 ` Leo Famulari
2017-02-21 7:50 ` Ricardo Wurmus
2017-02-21 17:30 ` Ricardo Wurmus
2017-02-21 17:47 ` bug#25177: " Leo Famulari
2017-02-21 22:15 ` Ricardo Wurmus
2017-02-22 12:42 ` Ricardo Wurmus
2017-02-22 12:57 ` Marius Bakke [this message]
2017-02-21 22:21 ` Ben Woodcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpcifknn.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=25177@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).