From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Wingo Subject: Re: GRUB EFI installation breakage Date: Wed, 23 Aug 2017 11:14:07 +0200 Message-ID: <87wp5uy7c0.fsf@igalia.com> References: <87efs34tfl.fsf@gnu.org> <87shgj2wzx.fsf@fastmail.com> <87fucjnsso.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkRkR-00047s-FU for guix-devel@gnu.org; Wed, 23 Aug 2017 05:14:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkRkL-0008Uw-MZ for guix-devel@gnu.org; Wed, 23 Aug 2017 05:14:51 -0400 In-Reply-To: <87fucjnsso.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 23 Aug 2017 00:25:59 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel On Wed 23 Aug 2017 00:25, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Marius Bakke skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Hello, >>> >>> To reconfigure my system on UEFI, I had to apply this patch: >>> >>> modified gnu/bootloader/grub.scm >>> @@ -401,7 +401,8 @@ submenu \"GNU system, old configurations...\" {~%") >>> ;; root partition. >>> (setenv "GRUB_ENABLE_CRYPTODISK" "y") >>> (unless (zero? (system* grub-install "--boot-directory" instal= l-dir >>> - "--efi-directory" efi-dir)) >>> + ;; "--efi-directory" efi-dir >>> + )) >>> (error "failed to install GRUB (EFI)"))))) >>>=20=20 >>> >>> Before that =E2=80=98grub-install=E2=80=99 would fail because =E2=80=98= efi-dir=E2=80=99 would actually >>> be =E2=80=9C/dev/sda=E2=80=9D, which is what I have in the =E2=80=98dev= ice=E2=80=99 field of >>> =E2=80=98grub-configuration=E2=80=99. >>> >>> Removing the =E2=80=9C--efi-directory=E2=80=9D solves the problem becau= se =E2=80=98grub-install=E2=80=99 >>> automatically determines that the EFI directory is mounted at /boot/efi. >>> >>> I think 2941b347b664a3d3114de0ac95e28db78db66144 is bogus because it >>> assumes that the second argument of the gexp=E2=80=99d lambda is =E2=80= =98efi-dir=E2=80=99, >>> where in fact it is the =E2=80=98device=E2=80=99 field of the bootloade= r config. >>> >>> So what is the preferred fix? Simply remove =E2=80=9C--efi-directory= =E2=80=9D like I >>> did above, and rename =E2=80=98efi-dir=E2=80=99 to =E2=80=98device=E2= =80=99 to avoid the ambiguity? >>> Thoughts? >> >> Maybe we could rename "device" to something like "target" and update the >> documentation to mention that "target" means the _mounted_ EFI System >> Partition for grub-efi, but is typically a block device. > > You mean it=E2=80=99s a block device except for EFI, right? > So yes, we can rename =E2=80=98device=E2=80=99 to =E2=80=98target=E2=80= =99, and we should at least > document what you wrote. Hi! Sorry for causing problems. For EFI, we shouldn't specify a block device AFAIU -- if anything, we should specify the location of the EFI directory (though it defaults to /boot/efi). My intention was to change the meaning of "device" for EFI to be the mounted EFI directory. But really I think we should recommend getting rid of this configuration option, at least in our EFI examples, as a default mount path of /boot/efi will be good enough I think. I can update the doc and examples -- will do that now. Andy