* Re: 01/01: gnu: red-eclipse: Add store "data" package path as default. [not found] ` <20171010122631.845F9201F1@vcs0.savannah.gnu.org> @ 2017-10-10 14:36 ` Leo Famulari 2017-10-10 23:34 ` Kei Kebreau 0 siblings, 1 reply; 3+ messages in thread From: Leo Famulari @ 2017-10-10 14:36 UTC (permalink / raw) To: guix-devel; +Cc: Kei Kebreau [-- Attachment #1: Type: text/plain, Size: 1375 bytes --] On Tue, Oct 10, 2017 at 08:26:31AM -0400, Kei Kebreau wrote: > kkebreau pushed a commit to branch master > in repository guix. > > commit 42abb842f64f5dd7834cabd445a5f4d01f1e68a4 > Author: Adonay Felipe Nogueira <adfeno@hyperbola.info> > Date: Sun Aug 20 15:28:20 2017 -0300 > > gnu: red-eclipse: Add store "data" package path as default. > > * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version > respect documentation. > [arguments]: Add "prefix" to make-flags. Add > "add-store-data-package-path-as-default" phase. Improve "copy-data" phase. > > Signed-off-by: Kei Kebreau <kkebreau@posteo.net> > --- > gnu/packages/games.scm | 110 ++++++++++++++++++++++++++++++------------------- > 1 file changed, 68 insertions(+), 42 deletions(-) [...] > @@ -133,6 +133,7 @@ > #:use-module (gnu packages gnuzilla) > #:use-module (gnu packages icu4c) > #:use-module (gnu packages networking) > + #:use-module (guix build utils) > #:use-module (guix build-system gnu) > #:use-module (guix build-system haskell) > #:use-module (guix build-system python) This module import created an ambiguous reference to 'which': WARNING: (gnu packages games): `which' imported from both (gnu packages base) and (guix build utils) I don't know if it will be a problem in practice. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 01/01: gnu: red-eclipse: Add store "data" package path as default. 2017-10-10 14:36 ` 01/01: gnu: red-eclipse: Add store "data" package path as default Leo Famulari @ 2017-10-10 23:34 ` Kei Kebreau 2017-10-12 8:48 ` Ludovic Courtès 0 siblings, 1 reply; 3+ messages in thread From: Kei Kebreau @ 2017-10-10 23:34 UTC (permalink / raw) To: Leo Famulari; +Cc: guix-devel, Kei Kebreau [-- Attachment #1: Type: text/plain, Size: 1600 bytes --] Leo Famulari <leo@famulari.name> writes: > On Tue, Oct 10, 2017 at 08:26:31AM -0400, Kei Kebreau wrote: >> kkebreau pushed a commit to branch master >> in repository guix. >> >> commit 42abb842f64f5dd7834cabd445a5f4d01f1e68a4 >> Author: Adonay Felipe Nogueira <adfeno@hyperbola.info> >> Date: Sun Aug 20 15:28:20 2017 -0300 >> >> gnu: red-eclipse: Add store "data" package path as default. >> >> * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version >> respect documentation. >> [arguments]: Add "prefix" to make-flags. Add >> "add-store-data-package-path-as-default" phase. Improve "copy-data" phase. >> >> Signed-off-by: Kei Kebreau <kkebreau@posteo.net> >> --- >> gnu/packages/games.scm | 110 ++++++++++++++++++++++++++++++------------------- >> 1 file changed, 68 insertions(+), 42 deletions(-) > > [...] > >> @@ -133,6 +133,7 @@ >> #:use-module (gnu packages gnuzilla) >> #:use-module (gnu packages icu4c) >> #:use-module (gnu packages networking) >> + #:use-module (guix build utils) >> #:use-module (guix build-system gnu) >> #:use-module (guix build-system haskell) >> #:use-module (guix build-system python) > > This module import created an ambiguous reference to 'which': > > WARNING: (gnu packages games): `which' imported from both (gnu > packages base) and (guix build utils) > > I don't know if it will be a problem in practice. It looks like Ludovic took care of this in commit db9c49f4999d4e5f6eb0565a6a80892131c55670. Thank you for the notification, though. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 01/01: gnu: red-eclipse: Add store "data" package path as default. 2017-10-10 23:34 ` Kei Kebreau @ 2017-10-12 8:48 ` Ludovic Courtès 0 siblings, 0 replies; 3+ messages in thread From: Ludovic Courtès @ 2017-10-12 8:48 UTC (permalink / raw) To: Kei Kebreau; +Cc: guix-devel, Kei Kebreau Kei Kebreau <kkebreau@posteo.net> skribis: > Leo Famulari <leo@famulari.name> writes: > >> On Tue, Oct 10, 2017 at 08:26:31AM -0400, Kei Kebreau wrote: >>> kkebreau pushed a commit to branch master >>> in repository guix. >>> >>> commit 42abb842f64f5dd7834cabd445a5f4d01f1e68a4 >>> Author: Adonay Felipe Nogueira <adfeno@hyperbola.info> >>> Date: Sun Aug 20 15:28:20 2017 -0300 >>> >>> gnu: red-eclipse: Add store "data" package path as default. >>> >>> * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version >>> respect documentation. >>> [arguments]: Add "prefix" to make-flags. Add >>> "add-store-data-package-path-as-default" phase. Improve "copy-data" phase. >>> >>> Signed-off-by: Kei Kebreau <kkebreau@posteo.net> >>> --- >>> gnu/packages/games.scm | 110 ++++++++++++++++++++++++++++++------------------- >>> 1 file changed, 68 insertions(+), 42 deletions(-) >> >> [...] >> >>> @@ -133,6 +133,7 @@ >>> #:use-module (gnu packages gnuzilla) >>> #:use-module (gnu packages icu4c) >>> #:use-module (gnu packages networking) >>> + #:use-module (guix build utils) >>> #:use-module (guix build-system gnu) >>> #:use-module (guix build-system haskell) >>> #:use-module (guix build-system python) >> >> This module import created an ambiguous reference to 'which': >> >> WARNING: (gnu packages games): `which' imported from both (gnu >> packages base) and (guix build utils) >> >> I don't know if it will be a problem in practice. > > It looks like Ludovic took care of this in commit > db9c49f4999d4e5f6eb0565a6a80892131c55670. Thank you for the > notification, though. Right, I had overlooked Leo’s message. It was indeed a problem in practice, which prevented evaluation: packages such as ‘crawl-tiles’ were getting the procedure instead of the package as an input, which is invalid. Ludo’. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-12 8:48 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20171010122630.7275.20219@vcs0.savannah.gnu.org> [not found] ` <20171010122631.845F9201F1@vcs0.savannah.gnu.org> 2017-10-10 14:36 ` 01/01: gnu: red-eclipse: Add store "data" package path as default Leo Famulari 2017-10-10 23:34 ` Kei Kebreau 2017-10-12 8:48 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).